Bug 1417200: Stop using -moz-border-*-colors in forms.css. r?xidorn draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Wed, 29 Nov 2017 11:34:31 +0100
changeset 706456 63f628fa2c18084a85069d78d1273a9cb2b8c627
parent 706455 6689a5c64d3f681c795e842dcd42a3e0bc26afae
child 742656 cc7555318729f99a618d4381fe8920e58f9c16f9
push id91800
push userbmo:emilio@crisal.io
push dateFri, 01 Dec 2017 22:19:57 +0000
reviewersxidorn
bugs1417200
milestone59.0a1
Bug 1417200: Stop using -moz-border-*-colors in forms.css. r?xidorn This removes one px of "padding" in: <progress style="-moz-appearance: none"></progress> But it'd be worse to not be able as an author to override those somehow. MozReview-Commit-ID: EFZIBHaUskM
layout/reftests/forms/progress/style.css
layout/style/res/forms.css
--- a/layout/reftests/forms/progress/style.css
+++ b/layout/reftests/forms/progress/style.css
@@ -1,21 +1,19 @@
 div.progress-element {
   -moz-appearance: progressbar;
   display: inline-block;
   height: 1em;
   width: 10em;
   vertical-align: -0.2em;
 
   /* Default style in case of there is -moz-appearance: none; */
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDShadow #e6e6e6;
-  -moz-border-right-colors: ThreeDHighlight #e6e6e6;
-  -moz-border-bottom-colors: ThreeDHighlight #e6e6e6;
-  -moz-border-left-colors: ThreeDShadow #e6e6e6;
+  border: 1px solid ThreeDShadow;
+  border-right-color: ThreeDHighlight;
+  border-bottom-color: ThreeDHighlight;
   background-color: #e6e6e6;
 }
 
 div.progress-element.vertical {
   height: 10em;
   width: 1em;
 }
 
--- a/layout/style/res/forms.css
+++ b/layout/style/res/forms.css
@@ -834,22 +834,20 @@ output:-moz-ui-invalid {
 }
 
 progress {
   -moz-appearance: progressbar;
   display: inline-block;
   vertical-align: -0.2em;
 
   /* Default style in case of there is -moz-appearance: none; */
-  border: 2px solid;
+  border: 1px solid ThreeDShadow;
+  border-right-color: ThreeDHighlight;
+  border-bottom-color: ThreeDHighlight;
   /* #e6e6e6 is a light gray. */
-  -moz-border-top-colors: ThreeDShadow #e6e6e6;
-  -moz-border-right-colors: ThreeDHighlight #e6e6e6;
-  -moz-border-bottom-colors: ThreeDHighlight #e6e6e6;
-  -moz-border-left-colors: ThreeDShadow #e6e6e6;
   background-color: #e6e6e6;
 }
 
 ::-moz-progress-bar {
   /* Prevent styling that would change the type of frame we construct. */
   display: inline-block ! important;
   float: none ! important;
   position: static ! important;