Bug 1421478: Clarify comment in handlerDataCleanup.h. r?aklotz draft
authorJames Teh <jteh@mozilla.com>
Wed, 29 Nov 2017 10:18:01 +1000
changeset 704813 11c5f2f6a1411a6a193168bb5cbb5f319fa27496
parent 704794 8ab8603daa264735093616c93ba861840dee32c5
child 742166 b1e7ae9c12236cdadc04f48af82300de59566b47
push id91254
push userbmo:jteh@mozilla.com
push dateWed, 29 Nov 2017 00:35:11 +0000
reviewersaklotz
bugs1421478
milestone59.0a1
Bug 1421478: Clarify comment in handlerDataCleanup.h. r?aklotz MozReview-Commit-ID: EVzuqVMl7Ck
accessible/ipc/win/handler/HandlerDataCleanup.h
--- a/accessible/ipc/win/handler/HandlerDataCleanup.h
+++ b/accessible/ipc/win/handler/HandlerDataCleanup.h
@@ -11,18 +11,20 @@
 #include "HandlerData.h"
 
 namespace mozilla {
 namespace a11y {
 
 inline void
 ReleaseStaticIA2DataInterfaces(StaticIA2Data& aData)
 {
-  // Only interfaces of the IA2 object should be released here, never other
-  // objects!
+  // Only interfaces of the proxied object wrapped by this handler should be
+  // released here, never other objects!
+  // For example, if StaticIA2Data were to include accParent in future,
+  // that must not be released here.
   if (aData.mIA2) {
     aData.mIA2->Release();
   }
   if (aData.mIEnumVARIANT) {
     aData.mIEnumVARIANT->Release();
   }
   if (aData.mIAHypertext) {
     aData.mIAHypertext->Release();