Bug 1407693 - Part 3 - Mark two areas where tests are currently broken and needing of feedback on the right fix draft
authorAlex Gaynor <agaynor@mozilla.com>
Mon, 27 Nov 2017 14:29:18 -0600
changeset 749728 2dd2130fc2d1332d724b471d992a5d4af6e3ae4b
parent 749727 a64012ae750d330ef6e557cbb16f5e74c3ce001e
push id97482
push userbmo:agaynor@mozilla.com
push dateWed, 31 Jan 2018 22:05:51 +0000
bugs1407693
milestone60.0a1
Bug 1407693 - Part 3 - Mark two areas where tests are currently broken and needing of feedback on the right fix MozReview-Commit-ID: 1INP0iwf3Iv
toolkit/components/extensions/ExtensionXPCShellUtils.jsm
--- a/toolkit/components/extensions/ExtensionXPCShellUtils.jsm
+++ b/toolkit/components/extensions/ExtensionXPCShellUtils.jsm
@@ -642,16 +642,20 @@ var ExtensionTestUtils = {
       },
 
       QueryInterface: XPCOMUtils.generateQI([Ci.nsIDirectoryServiceProvider]),
     };
     Services.dirsvc.registerProvider(dirProvider);
 
 
     scope.registerCleanupFunction(() => {
+      // TODO: On Windows, we can't delete a folder when it contains a file
+      // which is currently open. The crash reporter opens a file in the tmp
+      // directory and gives an FD to the child. Until the child exits, it
+      // stays open...
       tmpD.remove(true);
       Services.dirsvc.unregisterProvider(dirProvider);
 
       this.currentScope = null;
     });
   },
 
   addonManagerStarted: false,