Bug 1420774 - Drop unnecessary virtual from Animation methods. r?boris draft
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Mon, 27 Nov 2017 07:44:53 +0900
changeset 703544 8d55e0c84b097fc6fbdc4b309f652e75a7031148
parent 703543 8de465953e20c1332f94c1b0bc268be423790048
child 741803 b01eba1ab2bd0074f812ae85fa454ed9f9e71fc1
push id90850
push userhikezoe@mozilla.com
push dateSun, 26 Nov 2017 22:45:19 +0000
reviewersboris
bugs1420774
milestone59.0a1
Bug 1420774 - Drop unnecessary virtual from Animation methods. r?boris MozReview-Commit-ID: wRrKFbjsTx
dom/animation/Animation.h
--- a/dom/animation/Animation.h
+++ b/dom/animation/Animation.h
@@ -107,22 +107,22 @@ public:
   void SetStartTime(const Nullable<TimeDuration>& aNewStartTime);
   Nullable<TimeDuration> GetCurrentTime() const;
   void SetCurrentTime(const TimeDuration& aNewCurrentTime);
   double PlaybackRate() const { return mPlaybackRate; }
   void SetPlaybackRate(double aPlaybackRate);
   AnimationPlayState PlayState() const;
   bool Pending() const { return mPendingState != PendingState::NotPending; }
   virtual Promise* GetReady(ErrorResult& aRv);
-  virtual Promise* GetFinished(ErrorResult& aRv);
+  Promise* GetFinished(ErrorResult& aRv);
   void Cancel();
-  virtual void Finish(ErrorResult& aRv);
+  void Finish(ErrorResult& aRv);
   virtual void Play(ErrorResult& aRv, LimitBehavior aLimitBehavior);
   virtual void Pause(ErrorResult& aRv);
-  virtual void Reverse(ErrorResult& aRv);
+  void Reverse(ErrorResult& aRv);
   bool IsRunningOnCompositor() const;
   IMPL_EVENT_HANDLER(finish);
   IMPL_EVENT_HANDLER(cancel);
 
   // Wrapper functions for Animation DOM methods when called
   // from script.
   //
   // We often use the same methods internally and from script but when called