Bug 1420110 - remove browser.tabs.drawInTitlebar check from nsLookAndFeel, r?jhorak draft
authorMartin Stransky <stransky@redhat.com>
Thu, 23 Nov 2017 21:00:12 +0100
changeset 702780 653cb3f2aca64076505cb40b3200821978807cea
parent 702588 b6bed1b710c3e22cab49f22f1b5f44d80286bcb9
child 741581 54ec0f8f00f3e7c76fa20d34ad98186f883452d3
push id90613
push userstransky@redhat.com
push dateThu, 23 Nov 2017 20:05:56 +0000
reviewersjhorak
bugs1420110
milestone59.0a1
Bug 1420110 - remove browser.tabs.drawInTitlebar check from nsLookAndFeel, r?jhorak The browser.tabs.drawInTitlebar check at nsLookAndFeel is redundant, breaks Thunderbird and dynamic titlebar rendering change. Let's use browser.tabs.drawInTitlebar at browser level and when enabled configure titlebar visibility by moz_gtk* media atoms. MozReview-Commit-ID: IhCYmXgVME7
widget/gtk/nsLookAndFeel.cpp
--- a/widget/gtk/nsLookAndFeel.cpp
+++ b/widget/gtk/nsLookAndFeel.cpp
@@ -1075,21 +1075,16 @@ nsLookAndFeel::EnsureInit()
                       &mFieldFontName, &mFieldFontStyle);
 
     gtk_widget_destroy(window);
     g_object_unref(labelWidget);
 
     // Require GTK 3.10 for GtkHeaderBar support and compatible window manager.
     mCSDAvailable = (gtk_check_version(3, 10, 0) == nullptr &&
         nsWindow::GetCSDSupportLevel() != nsWindow::CSD_SUPPORT_NONE);
-    if (mCSDAvailable) {
-        mCSDAvailable =
-            mozilla::Preferences::GetBool("browser.tabs.drawInTitlebar",
-                                          false);
-    }
 
     // We need to initialize whole CSD config explicitly because it's queried
     // as -moz-gtk* media features.
     mCSDCloseButton = true;
     mCSDMaximizeButton = false;
     mCSDMinimizeButton = false;
 
     if (mCSDAvailable) {