Bug 1419666 - MemoryBlockCacheTelemetry::NotifyCombinedSizeGrown() should assert the main thread only for the first call. draft
authorJW Wang <jwwang@mozilla.com>
Wed, 22 Nov 2017 15:06:53 +0800
changeset 702369 103f5e6ad9f7212cfb5e33da96dc1da3b366cd1a
parent 701671 19b4ab022ab7b68b66f50e61afd313137f8baec4
child 741440 7aaaafed22859787ccab9898c08bdea32387c520
push id90454
push userjwwang@mozilla.com
push dateThu, 23 Nov 2017 02:40:16 +0000
bugs1419666
milestone59.0a1
Bug 1419666 - MemoryBlockCacheTelemetry::NotifyCombinedSizeGrown() should assert the main thread only for the first call. For the 2nd call might happen off the main thread. MozReview-Commit-ID: 701p2GGuiEo
dom/media/MemoryBlockCache.cpp
--- a/dom/media/MemoryBlockCache.cpp
+++ b/dom/media/MemoryBlockCache.cpp
@@ -66,20 +66,19 @@ private:
 
 NS_IMPL_ISUPPORTS(MemoryBlockCacheTelemetry,
                   nsIObserver,
                   nsISupportsWeakReference)
 
 /* static */ size_t
 MemoryBlockCacheTelemetry::NotifyCombinedSizeGrown(size_t aNewSize)
 {
-  NS_ASSERTION(NS_IsMainThread(), "Only call on main thread");
-
   // Ensure gMemoryBlockCacheTelemetry exists.
   if (!gMemoryBlockCacheTelemetry) {
+    MOZ_ASSERT(NS_IsMainThread());
     gMemoryBlockCacheTelemetry = new MemoryBlockCacheTelemetry();
 
     nsCOMPtr<nsIObserverService> observerService =
       mozilla::services::GetObserverService();
     if (observerService) {
       observerService->AddObserver(
         gMemoryBlockCacheTelemetry, "profile-change-teardown", true);
     }