Bug 1419964: Add a display: contents TODO. r?mats draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Wed, 22 Nov 2017 23:57:17 +0100
changeset 702287 7efcc3587bfad7c27094760ebb3fc33d3d2ca776
parent 702286 81547e016bf6438686f37c8e11059e5e31a5e69e
child 741413 a0e5d56b5d2781cdb06b951bee22ff14ab4465dd
push id90427
push userbmo:emilio@crisal.io
push dateWed, 22 Nov 2017 22:58:44 +0000
reviewersmats
bugs1419964
milestone59.0a1
Bug 1419964: Add a display: contents TODO. r?mats MozReview-Commit-ID: 6u8FSphq8jw
layout/base/nsCSSFrameConstructor.cpp
--- a/layout/base/nsCSSFrameConstructor.cpp
+++ b/layout/base/nsCSSFrameConstructor.cpp
@@ -7669,16 +7669,19 @@ nsCSSFrameConstructor::ContentAppended(n
   // where frames can be moved around, determine if the list is for the
   // start or end of the block.
   if (nsLayoutUtils::GetAsBlock(parentFrame) && !haveFirstLetterStyle &&
       !haveFirstLineStyle && !parentIBSplit) {
     items.SetLineBoundaryAtStart(!prevSibling ||
                                  !prevSibling->IsInlineOutside() ||
                                  prevSibling->IsBrFrame());
     // :after content can't be <br> so no need to check it
+    //
+    // FIXME(emilio): A display: contents sibling could! Write a test-case and
+    // fix.
     items.SetLineBoundaryAtEnd(
         !nextSibling || !nextSibling->IsInlineOutside());
   }
   // To suppress whitespace-only text frames, we have to verify that
   // our container's DOM child list matches its flattened tree child list.
   items.SetParentHasNoXBLChildren(haveNoXBLChildren);
 
   nsFrameItems frameItems;