Bug 1319222 - Change --param flag to be multiple arguments; r=chmanchester draft
authorMike Shal <mshal@mozilla.com>
Wed, 22 Nov 2017 14:50:24 -0500 (2017-11-22)
changeset 707632 69fbea3ee15901f98f594366414106bdede8983d
parent 707631 c831cf9c72cf5c340c8f108e59d279ab53fc421f
child 707633 970c31d7d35d491a533991821a9dbccc2e373704
push id92183
push userbmo:mshal@mozilla.com
push dateTue, 05 Dec 2017 16:33:02 +0000 (2017-12-05)
reviewerschmanchester
bugs1319222, 10000
milestone59.0a1
Bug 1319222 - Change --param flag to be multiple arguments; r=chmanchester This flag should be two parameters, the first of which is '--param', and the second is the parameter, such as 'inline-unit-growth=10000'. The recursive make backend lets this slide at the moment because PerSourceFlags aren't shell_quoted() there. MozReview-Commit-ID: 8vblYqCGxwg
gfx/cairo/libpixman/src/moz.build
--- a/gfx/cairo/libpixman/src/moz.build
+++ b/gfx/cairo/libpixman/src/moz.build
@@ -105,18 +105,18 @@ elif 'arm' in CONFIG['OS_TEST']:
 
 if use_mmx:
     DEFINES['USE_MMX'] = True
     SOURCES += ['pixman-mmx.c']
     SOURCES['pixman-mmx.c'].flags += CONFIG['MMX_FLAGS']
     if CONFIG['GNU_CC']:
         SOURCES['pixman-mmx.c'].flags += [
             '-Winline',
-            '--param inline-unit-growth=10000',
-            '--param large-function-growth=10000',
+            '--param', 'inline-unit-growth=10000',
+            '--param', 'large-function-growth=10000',
         ]
 
 if use_sse2:
     DEFINES['USE_SSE'] = True
     DEFINES['USE_SSE2'] = True
     SOURCES += ['pixman-sse2.c']
     SOURCES['pixman-sse2.c'].flags += CONFIG['SSE_FLAGS'] + CONFIG['SSE2_FLAGS']
     if CONFIG['GNU_CC']: