Bug 1419792 - Shapes highlighter drawn inaccurately for shape-outside with margins. r=gl draft
authorMike Park <mikeparkms@gmail.com>
Wed, 22 Nov 2017 12:05:55 -0500
changeset 702167 e20608325358b1d5e073782b6893dfd192bf2ce0
parent 702036 05a913c5cf3f9f9577d103352c6a593b8fa4fd60
child 741395 4b2a3bf1d338bb77cc97f1a13aafc0e8ac403fb3
push id90408
push userbmo:mpark@mozilla.com
push dateWed, 22 Nov 2017 21:16:31 +0000
reviewersgl
bugs1419792
milestone59.0a1
Bug 1419792 - Shapes highlighter drawn inaccurately for shape-outside with margins. r=gl MozReview-Commit-ID: 1MGCvsDXJ6O
devtools/server/actors/highlighters/shapes.js
--- a/devtools/server/actors/highlighters/shapes.js
+++ b/devtools/server/actors/highlighters/shapes.js
@@ -1447,18 +1447,18 @@ class ShapesHighlighter extends AutoRefr
       coordParser: this.ellipsePoints.bind(this)
     }, {
       name: "inset",
       prefix: "inset(",
       coordParser: this.insetPoints.bind(this)
     }];
     const geometryTypes = ["margin", "border", "padding", "content"];
 
-    // default to border
-    let referenceBox = "border";
+    // default to border for clip-path, and margin for shape-outside
+    let referenceBox = this.property === "clip-path" ? "border" : "margin";
     for (let geometry of geometryTypes) {
       if (definition.includes(geometry)) {
         referenceBox = geometry;
       }
     }
     this.referenceBox = referenceBox;
 
     this.useStrokeBox = definition.includes("stroke-box");