Bug 1418387 - Fix bugs that C++ should really catch for us. r?botond draft
authorKartikaya Gupta <kgupta@mozilla.com>
Fri, 24 Nov 2017 16:23:03 -0500
changeset 703336 cf62c6697dc94da07ee8d9b9906693fd3f89e557
parent 703335 81d3e4a2f3f3e98042e24159fe03331fa3534de4
child 703337 724c6c9cbc85166da0f2c9d6f86ae45b169caf5c
push id90784
push userkgupta@mozilla.com
push dateFri, 24 Nov 2017 21:25:10 +0000
reviewersbotond
bugs1418387
milestone59.0a1
Bug 1418387 - Fix bugs that C++ should really catch for us. r?botond MozReview-Commit-ID: EZWPBruZXdv
gfx/layers/LayerAttributes.h
layout/painting/nsDisplayList.h
--- a/gfx/layers/LayerAttributes.h
+++ b/gfx/layers/LayerAttributes.h
@@ -248,17 +248,17 @@ public:
     return mIsFixedPosition;
   }
   FrameMetrics::ViewID ScrollbarTargetContainerId() const {
     return mScrollbarTargetContainerId;
   }
   const ScrollThumbData& ThumbData() const {
     return mThumbData;
   }
-  float IsScrollbarContainer() const {
+  bool IsScrollbarContainer() const {
     return mIsScrollbarContainer;
   }
   gfx::CompositionOp MixBlendMode() const {
     return mMixBlendMode;
   }
   bool ForceIsolatedGroup() const {
     return mForceIsolatedGroup;
   }
--- a/layout/painting/nsDisplayList.h
+++ b/layout/painting/nsDisplayList.h
@@ -5111,17 +5111,17 @@ public:
                     bool aForceActive = true,
                     bool aClearClipChain = false);
 #ifdef NS_BUILD_REFCNT_LOGGING
   virtual ~nsDisplayOwnLayer();
 #endif
   nsDisplayOwnLayer(nsDisplayListBuilder* aBuilder, const nsDisplayOwnLayer& aOther)
     : nsDisplayWrapList(aBuilder, aOther)
     , mFlags(aOther.mFlags)
-    , mScrollTarget(aOther.mFlags)
+    , mScrollTarget(aOther.mScrollTarget)
     , mThumbData(aOther.mThumbData)
     , mForceActive(aOther.mForceActive)
     , mWrAnimationId(aOther.mWrAnimationId)
   {
     MOZ_COUNT_CTOR(nsDisplayOwnLayer);
   }
 
   virtual bool ShouldBuildLayerEvenIfInvisible(nsDisplayListBuilder* aBuilder) const override;