Bug 1405252 - Enable browser_webconsole_console_logging_workers_api.js in the new frontend; r=Honza. draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Tue, 21 Nov 2017 09:23:31 +0100
changeset 715246 e92c61b5e7376866521e2b466443039f8bab5927
parent 715168 351c75ab74c9a83db5c0662ba271b49479adb1f1
child 715250 d52018cb0124cdddc5e8f33f34db298be6b8d9fb
push id94108
push userbmo:nchevobbe@mozilla.com
push dateWed, 03 Jan 2018 10:17:41 +0000
reviewersHonza
bugs1405252
milestone59.0a1
Bug 1405252 - Enable browser_webconsole_console_logging_workers_api.js in the new frontend; r=Honza. MozReview-Commit-ID: I7b45uLfNkw
devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_console_logging_workers_api.js
devtools/client/webconsole/new-console-output/test/mochitest/test-console-workers.html
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -244,17 +244,16 @@ skip-if = true # Bug 1406038
 [browser_webconsole_close_sidebar.js]
 [browser_webconsole_closure_inspection.js]
 skip-if = true # Bug 1405250
 [browser_webconsole_console_api_iframe.js]
 [browser_webconsole_console_dir.js]
 [browser_webconsole_console_dir_uninspectable.js]
 [browser_webconsole_console_group.js]
 [browser_webconsole_console_logging_workers_api.js]
-skip-if = true # Bug 1405252
 [browser_webconsole_console_table.js]
 [browser_webconsole_context_menu_copy_entire_message.js]
 subsuite = clipboard
 skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts
 [browser_webconsole_context_menu_copy_link_location.js]
 subsuite = clipboard
 skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts
 [browser_webconsole_context_menu_copy_object.js]
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_console_logging_workers_api.js
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_console_logging_workers_api.js
@@ -4,36 +4,23 @@
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
 // Tests that the basic console.log()-style APIs and filtering work for
 // sharedWorkers
 
 "use strict";
 
 const TEST_URI = "http://example.com/browser/devtools/client/webconsole/" +
-                 "test/test-console-workers.html";
-
-add_task(function* () {
-  yield loadTab(TEST_URI);
-
-  let hud = yield openConsole();
-
-  yield waitForMessages({
-    webconsole: hud,
-    messages: [{
-      text: "foo-bar-shared-worker"
-    }],
-  });
+                 "new-console-output/test/mochitest/test-console-workers.html";
 
-  hud.setFilterState("sharedworkers", false);
-
-  is(hud.outputNode.querySelectorAll(".filtered-by-type").length, 1,
-     "1 message hidden for sharedworkers (logging turned off)");
-
-  hud.setFilterState("sharedworkers", true);
+add_task(async function () {
+  const hud = await openNewTabAndConsole(TEST_URI);
+  const message = await waitFor(() => findMessage(hud, "foo-bar-shared-worker"));
+  is(
+    message.querySelector(".message-body").textContent,
+    `foo-bar-shared-worker Object { foo: "bar" }`,
+    "log from SharedWorker is displayed as expected"
+  );
 
-  is(hud.outputNode.querySelectorAll(".filtered-by-type").length, 0,
-     "1 message shown for sharedworkers (logging turned on)");
-
-  hud.setFilterState("sharedworkers", false);
-
+  let onMessagesCleared = hud.jsterm.once("messages-cleared");
   hud.jsterm.clearOutput(true);
+  await onMessagesCleared;
 });
--- a/devtools/client/webconsole/new-console-output/test/mochitest/test-console-workers.html
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/test-console-workers.html
@@ -2,12 +2,15 @@
      http://creativecommons.org/publicdomain/zero/1.0/ -->
 <!DOCTYPE HTML>
 <html dir="ltr" xml:lang="en-US" lang="en-US"><head>
     <meta charset="utf-8">
     <title>Console test</title>
   </head>
   <body>
     <script type="text/javascript">
-var sw = new SharedWorker('data:application/javascript,console.log("foo-bar-shared-worker");');
+      new SharedWorker(`data:application/javascript,
+        console.log("foo-bar-shared-worker", {foo: "bar"});
+        self.close();
+      `);
     </script>
   </body>
 </html>