Bug 1419182 - Clean up value checking; r?build
MozReview-Commit-ID: LAS0Iaf40nI
--- a/build/compare-mozconfig/compare-mozconfigs.py
+++ b/build/compare-mozconfig/compare-mozconfigs.py
@@ -31,18 +31,17 @@ def verify_mozconfigs(mozconfig_pair, ni
are pairs containing the mozconfig's identifier and the list of lines in
the mozconfig."""
# unpack the pairs to get the names, the names are just for
# identifying the mozconfigs when logging the error messages
mozconfig_name, mozconfig_lines = mozconfig_pair
nightly_mozconfig_name, nightly_mozconfig_lines = nightly_mozconfig_pair
- missing_args = mozconfig_lines == [] or nightly_mozconfig_lines == []
- if missing_args:
+ if not mozconfig_lines or not nightly_mozconfig_lines:
log.info("Missing mozconfigs to compare for %s" % platform)
return False
success = True
diff_instance = difflib.Differ()
diff_result = diff_instance.compare(mozconfig_lines, nightly_mozconfig_lines)
diff_list = list(diff_result)