Bug 1419141: Update thunderbird l10n-check step to match firefox. draft
authorTom Prince <mozilla@hocat.ca>
Mon, 20 Nov 2017 09:54:12 -0700
changeset 23169 e397a0b7d467055d6cedc6f40f36f91cf42a14cf
parent 23168 20e4e9c918e2ed8c074962d6d64b4fd3ad459b64
push id151
push userbmo:mozilla@hocat.ca
push dateMon, 20 Nov 2017 19:52:35 +0000
bugs1419141, 1228289
Bug 1419141: Update thunderbird l10n-check step to match firefox. In particular, this picks up the fix from Bug 1228289. MozReview-Commit-ID: 1EoPMVUiqAb
mail/locales/Makefile.in
--- a/mail/locales/Makefile.in
+++ b/mail/locales/Makefile.in
@@ -187,21 +187,25 @@ ifeq (WINNT, $(OS_ARCH))
 	mv "$(DIST)/$(PKG_INST_PATH)$(PKG_INST_BASENAME).exe" \
 	   "$(UPLOAD_DIR)/$(PKG_INST_PATH)$(PKG_INST_BASENAME).exe"
 endif
 # Set the permissions that the folders will have in ftp once uploaded
 	chmod -vR 775 $(UPLOAD_DIR)
 
 # test target, depends on make package
 # try to repack x-test, with just toolkit/defines.inc being there
+l10n-check:: INNER_UNMAKE_PACKAGE=true
 l10n-check::
 	$(RM) -rf x-test
 	$(NSINSTALL) -D x-test/toolkit
 	echo '#define MOZ_LANG_TITLE Just testing' > x-test/toolkit/defines.inc
-	$(MAKE) installers-x-test L10NBASEDIR='$(PWD)'
+	$(MAKE) installers-x-test L10NBASEDIR='$(PWD)' \
+	    ZIP_IN='$(ZIP_IN)' WIN32_INSTALLER_IN='$(WIN32_INSTALLER_IN)' MOZ_SIMPLE_PACKAGE_NAME=
+	$(PYTHON) $(topsrcdir)/toolkit/mozapps/installer/unpack.py $(DIST)/l10n-stage/$(MOZ_PKG_DIR)$(_RESPATH)
+	cd $(DIST)/l10n-stage && test $$(cat $(MOZ_PKG_DIR)$(_RESPATH)/update.locale) = x-test
 
 ifdef MOZ_CALENDAR
 LIGHTNING_PATH=$(commtopobjdir)/calendar/lightning
 GDATA_PATH=$(commtopobjdir)/calendar/providers/gdata
 
 define run-calendar-rule
 $(MAKE) -C $(LIGHTNING_PATH) $(subst calendar-,,$@) AB_CD=$(AB_CD)
 $(MAKE) -C $(GDATA_PATH) $(subst calendar-,,$@) AB_CD=$(AB_CD)