Bug 1418573 - Remove -Wc++14-compat flag because we now compile with -std=c++14. r?rillian draft
authorChris Peterson <cpeterson@mozilla.com>
Fri, 17 Nov 2017 23:58:04 -0800
changeset 700095 df0dc462a0ccb6b416aedb259ca4d0a38441e23c
parent 700056 daa0dcd1616cbdf5541f548e44662d20d6d67d99
child 740785 6cd319bf8d1cc8f0e755ac458f91c2527a99622e
push id89740
push usercpeterson@mozilla.com
push dateSat, 18 Nov 2017 08:09:13 +0000
reviewersrillian
bugs1418573
milestone59.0a1
Bug 1418573 - Remove -Wc++14-compat flag because we now compile with -std=c++14. r?rillian -Wc++14-compat warns about code whose meaning differs between C++11 and C++14. We want the new C++14 meanings, so we don't need to warn about these differences. We still want -Wc++1z-compat because we want to know about C++14 code whose meaning will change in C++17 or C++20. MozReview-Commit-ID: 1CD11l2Fd86
build/moz.configure/warnings.configure
--- a/build/moz.configure/warnings.configure
+++ b/build/moz.configure/warnings.configure
@@ -49,18 +49,16 @@ add_gcc_warning('-Wno-invalid-offsetof',
 
 # catches objects passed by value to variadic functions.
 check_and_add_gcc_warning('-Wclass-varargs')
 
 # catches issues around loops
 check_and_add_gcc_warning('-Wloop-analysis')
 
 # catches C++ version forward-compat issues
-check_and_add_gcc_warning('-Wc++14-compat', cxx_compiler)
-check_and_add_gcc_warning('-Wc++14-compat-pedantic', cxx_compiler)
 check_and_add_gcc_warning('-Wc++1z-compat', cxx_compiler)
 
 # catches possible misuse of the comma operator
 check_and_add_gcc_warning('-Wcomma', cxx_compiler)
 
 # catches duplicated conditions in if-else-if chains
 check_and_add_gcc_warning('-Wduplicated-cond')