Bug 1411654 - Post: Cull unused variables; guard more with MOZ_BUILD_MOBILE_ANDROID_WITH_GRADLE. r=maliu
MozReview-Commit-ID: 8EGzVISIEQZ
--- a/mobile/android/base/Makefile.in
+++ b/mobile/android/base/Makefile.in
@@ -22,16 +22,18 @@ GARBAGE += \
FennecJNIWrappers.cpp \
FennecJNIWrappers.h \
$(NULL)
GARBAGE_DIRS += classes db jars res sync services generated
gradle_dir := $(topobjdir)/gradle/build/mobile/android
+ifndef MOZ_BUILD_MOBILE_ANDROID_WITH_GRADLE
+
# The bootclasspath is functionally identical to the classpath, but allows the
# classes given to redefine classes in core packages, such as java.lang.
# android.jar is here as it provides Android's definition of the Java Standard
# Library. The compatability lib here tweaks a few of the core classes to paint
# over changes in behaviour between versions.
JAVA_BOOTCLASSPATH := \
$(ANDROID_SDK)/android.jar \
$(NULL)
@@ -148,17 +150,16 @@ endif
# java_bundled_libs. See the note above.
# uniq purloined from http://stackoverflow.com/a/16151140.
uniq = $(if $1,$(firstword $1) $(call uniq,$(filter-out $(firstword $1),$1)))
java_bundled_libs := $(call uniq,$(java_bundled_libs))
java_bundled_libs := $(subst $(NULL) ,:,$(strip $(java_bundled_libs)))
-ifndef MOZ_BUILD_MOBILE_ANDROID_WITH_GRADLE
GECKOVIEW_JARS = \
constants.jar \
gecko-R.jar \
gecko-mozglue.jar \
gecko-util.jar \
gecko-view.jar \
sync-thirdparty.jar \
$(NULL)
@@ -180,26 +181,16 @@ FENNEC_JARS = \
gecko-thirdparty.jar \
services.jar \
$(NULL)
ifdef MOZ_ANDROID_MLS_STUMBLER
FENNEC_JARS += ../stumbler/stumbler.jar
endif
-else # MOZ_BUILD_MOBILE_ANDROID_WITH_GRADLE
-
-GECKOVIEW_JARS := $(gradle_dir)/geckoview/intermediates/bundles/debug/classes.jar
-FENNEC_JARS := $(gradle_dir)/app/intermediates/packaged/officialPhoton/debug/classes.jar
-
-$(GECKOVIEW_JARS): .gradle.deps
-$(FENNEC_JARS): .gradle.deps
-
-endif # MOZ_BUILD_MOBILE_ANDROID_WITH_GRADLE
-
geckoview_jars_classpath := $(subst $(NULL) ,:,$(strip $(GECKOVIEW_JARS)))
# All the jars we're compiling from source. (not to be confused with
# java_bundled_libs, which holds the jars which we're including as binaries).
ALL_JARS = \
$(GECKOVIEW_JARS) \
$(FENNEC_JARS) \
$(NULL)
@@ -237,16 +228,18 @@ library_jars := \
# MOZ_ANDROID_MMA requires MOZ_INSTALL_TRACKING, so we don't need a
# separate clause for MMA (Leanplum) support.
ifdef MOZ_INSTALL_TRACKING
library_jars += $(ANDROID_SDK)/optional/org.apache.http.legacy.jar
endif # MOZ_INSTALL_TRACKING
library_jars := $(subst $(NULL) ,:,$(strip $(library_jars)))
+endif # MOZ_BUILD_MOBILE_ANDROID_WITH_GRADLE
+
ifdef MOZ_BUILD_MOBILE_ANDROID_WITH_GRADLE
define gradle_command
$(1): $(2)
@$$(TOUCH) $$@
$$(topsrcdir)/mach android assemble-app
endef
# .gradle.deps: .aapt.deps FORCE