Bug 1417501 - Add devtools/client/netmonitor/test/shared-head.js in console browser.ini; r=ochameau. draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Wed, 15 Nov 2017 17:22:10 +0100
changeset 698367 70a21db32ab3aee38946cc962bede9689a86045b
parent 698261 45715ece25fcb064eee4f977ebd842d44a87f22b
child 740357 4fa2bba41de47b469b1cc3a72822620f6b66e018
push id89266
push userbmo:nchevobbe@mozilla.com
push dateWed, 15 Nov 2017 16:31:00 +0000
reviewersochameau
bugs1417501, 1404917
milestone59.0a1
Bug 1417501 - Add devtools/client/netmonitor/test/shared-head.js in console browser.ini; r=ochameau. In Bug 1404917, we introduced loading the /devtools/client/netmonitor/test/shared-head.js file in devtools/client/webconsole/new-console-output/test/mochitest/head.js. But, the shared file is not declared in browser.ini, which ends up making variabled from head.js inaccessible, and some tests that relies on them to fail. This was not picked up by TRY because the netmonitor tests are ran before the console's one, which loads devtools/client/netmonitor/test/shared-head.js . MozReview-Commit-ID: 80OOUHwjnWL
devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -161,16 +161,17 @@ support-files =
   test-sourcemap-error-02.js
   test-stacktrace-location-debugger-link.html
   test-trackingprotection-securityerrors.html
   test-webconsole-error-observer.html
   testscript.js
   !/devtools/client/netmonitor/test/sjs_cors-test-server.sjs
   !/image/test/mochitest/blue.png
   !/devtools/client/framework/test/shared-head.js
+  !/devtools/client/netmonitor/test/shared-head.js
 [browser_console.js]
 skip-if = true # Bug 1406060
 [browser_console_addonsdk_loader_exception.js]
 skip-if = true # Bug 1406060
 [browser_console_clear_method.js]
 skip-if = true # Bug 1406060
 [browser_console_consolejsm_output.js]
 skip-if = true # Bug 1406060