Bug 1415203 - Don't refuse to create WebRender commands due to -moz-border-*-colors on border sides that don't have a border. r?jrmuizel draft
authorMarkus Stange <mstange@themasta.com>
Tue, 14 Nov 2017 15:47:53 -0500
changeset 697853 25cbdd23f7b5591387d9ab5a920ae4ad5bc520fc
parent 697852 a75a90dd41aed4ba3191971defc7b604d35f2b72
child 740230 cdad7012cb7024b18c85da9da626de124c405e44
push id89123
push userbmo:mstange@themasta.com
push dateTue, 14 Nov 2017 20:49:00 +0000
reviewersjrmuizel
bugs1415203
milestone59.0a1
Bug 1415203 - Don't refuse to create WebRender commands due to -moz-border-*-colors on border sides that don't have a border. r?jrmuizel MozReview-Commit-ID: DPQQgds3GOk
layout/painting/nsCSSRenderingBorders.cpp
--- a/layout/painting/nsCSSRenderingBorders.cpp
+++ b/layout/painting/nsCSSRenderingBorders.cpp
@@ -3583,17 +3583,20 @@ nsCSSBorderRenderer::DrawBorders()
     }
   }
 }
 
 bool
 nsCSSBorderRenderer::CanCreateWebRenderCommands()
 {
   NS_FOR_CSS_SIDES(i) {
-    if (mCompositeColors[i] != nullptr) {
+    if (mCompositeColors[i] != nullptr &&
+        mBorderWidths[i] > 0.0f &&
+        mBorderStyles[i] != NS_STYLE_BORDER_STYLE_HIDDEN &&
+        mBorderStyles[i] != NS_STYLE_BORDER_STYLE_NONE) {
       return false;
     }
   }
 
   return true;
 }
 
 void