Bug 1385785 - Clicking on form autofill dropdown warning notes should not open preferences tab. r=lchang draft
authorRay Lin <ralin@mozilla.com>
Tue, 14 Nov 2017 14:54:25 +0800
changeset 697535 09a36c290c6cc281db55e1b828b86aa476d5890d
parent 697534 abb60753e5586e06ef5047c3de3d7708611ed37b
child 740148 4087fb325240fc118626a95a4d7a1393ee8f0af3
push id89034
push userbmo:ralin@mozilla.com
push dateTue, 14 Nov 2017 06:56:24 +0000
reviewerslchang
bugs1385785
milestone59.0a1
Bug 1385785 - Clicking on form autofill dropdown warning notes should not open preferences tab. r=lchang MozReview-Commit-ID: 4IWBroDQNT
browser/extensions/formautofill/content/formautofill.xml
--- a/browser/extensions/formautofill/content/formautofill.xml
+++ b/browser/extensions/formautofill/content/formautofill.xml
@@ -155,16 +155,20 @@
         </div>
         <div anonid="autofill-option-button" class="autofill-footer-row autofill-option-button">
         </div>
       </div>
     </xbl:content>
 
     <handlers>
       <handler event="click" button="0"><![CDATA[
+        if (this._warningTextBox.contains(event.originalTarget)) {
+          return;
+        }
+
         window.openPreferences("panePrivacy", {origin: "autofillFooter"});
       ]]></handler>
     </handlers>
 
     <implementation implements="nsIDOMXULSelectControlItemElement">
       <constructor>
         <![CDATA[
           this._itemBox = document.getAnonymousElementByAttribute(