Bug 1415448 - Update test descriptions in interfaces/Animatable/getAnimations.html; r?hiro draft
authorBrian Birtles <birtles@gmail.com>
Fri, 10 Nov 2017 16:56:53 +0900
changeset 696137 9d5d19938c3d39bdeefedddc5e6f53339d710987
parent 696136 c60a0e20c1c4a90aca1e67315ba3bb27dabfc0ff
child 696138 162942a6a67489d51ca50afe5114c83174948ac4
push id88646
push userbbirtles@mozilla.com
push dateFri, 10 Nov 2017 08:01:07 +0000
reviewershiro
bugs1415448
milestone58.0a1
Bug 1415448 - Update test descriptions in interfaces/Animatable/getAnimations.html; r?hiro We plan to merge in tests here from AnimationEffectTiming/getAnimations.html so in this patch we update the test descriptions first. MozReview-Commit-ID: HB3wquaPwmi
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/web-animations/interfaces/Animatable/getAnimations.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -585818,17 +585818,17 @@
    "284d173b6875923ddd894d2ac7498cd07311c001",
    "testharness"
   ],
   "web-animations/interfaces/Animatable/animate.html": [
    "dfba0ceb784a9ba847f0f0db1234a59c783ecfab",
    "testharness"
   ],
   "web-animations/interfaces/Animatable/getAnimations.html": [
-   "d516196c591dcf00b73f42ea9ab22118af88b9a4",
+   "9ced6f956324856d94538c3ea7304f37f3da10e6",
    "testharness"
   ],
   "web-animations/interfaces/Animation/cancel.html": [
    "d624285aa264c5b2d823e85fdbfa05f47f26e32a",
    "testharness"
   ],
   "web-animations/interfaces/Animation/constructor.html": [
    "24a0f7b8f147c12ca2a1aacefa62ab52670fa72c",
--- a/testing/web-platform/tests/web-animations/interfaces/Animatable/getAnimations.html
+++ b/testing/web-platform/tests/web-animations/interfaces/Animatable/getAnimations.html
@@ -7,64 +7,65 @@
 <script src="../../testcommon.js"></script>
 <body>
 <script>
 'use strict';
 
 test(function(t) {
   var div = createDiv(t);
   assert_array_equals(div.getAnimations(), []);
-}, 'Test getAnimations on element with no animations');
+}, 'Returns an empty array for an element with no animations');
 
 test(function(t) {
   var div = createDiv(t);
   var animationA = div.animate(null, 100 * MS_PER_SEC);
   var animationB = div.animate(null, 100 * MS_PER_SEC);
   assert_array_equals(div.getAnimations(), [animationA, animationB]);
-}, 'Test getAnimations on element with two animations');
+}, 'Returns both animations for an element with two animations');
 
 test(function(t) {
   var divA = createDiv(t);
   var divB = createDiv(t);
   var animationA = divA.animate(null, 100 * MS_PER_SEC);
   var animationB = divB.animate(null, 100 * MS_PER_SEC);
   assert_array_equals(divA.getAnimations(), [animationA], 'divA');
   assert_array_equals(divB.getAnimations(), [animationB], 'divB');
-}, 'Test getAnimations on separate elements with separate animations');
+}, 'Returns only the animations specific to each sibling element');
 
 test(function(t) {
   var divParent = createDiv(t);
   var divChild = createDiv(t);
   divParent.appendChild(divChild);
   var animationParent = divParent.animate(null, 100 * MS_PER_SEC);
   var animationChild = divChild.animate(null, 100 * MS_PER_SEC);
-  assert_array_equals(divParent.getAnimations(), [animationParent], 'divParent');
+  assert_array_equals(divParent.getAnimations(), [animationParent],
+                      'divParent');
   assert_array_equals(divChild.getAnimations(), [animationChild], 'divChild');
-}, 'Test getAnimations on parent and child elements with separate animations');
+}, 'Returns only the animations specific to each parent/child element');
 
 test(function(t) {
   var div = createDiv(t);
   var animation = div.animate(null, 100 * MS_PER_SEC);
   animation.finish();
   assert_array_equals(div.getAnimations(), []);
-}, 'Test getAnimations on element with finished fill none animation');
+}, 'Does not return finished animations that do not fill forwards');
 
 test(function(t) {
   var div = createDiv(t);
   var animation = div.animate(null, {
     duration: 100 * MS_PER_SEC,
     fill: 'forwards',
   });
   animation.finish();
   assert_array_equals(div.getAnimations(), [animation]);
-}, 'Test getAnimations on element with finished fill forwards animation');
+}, 'Returns finished animations that fill forwards');
 
 test(function(t) {
   var div = createDiv(t);
   var animation = div.animate(null, {
     duration: 100 * MS_PER_SEC,
     delay: 100 * MS_PER_SEC,
   });
   assert_array_equals(div.getAnimations(), [animation]);
-}, 'Test getAnimations on element with delayed animation');
+}, 'Returns animations in their delay phase');
 
 </script>
 </body>