Bug 1416052 - Remove OBJDIR_TARGETS; r=nalexander draft
authorGregory Szorc <gps@mozilla.com>
Thu, 09 Nov 2017 23:31:36 -0800
changeset 697424 07fa7f0e15f84fbc0bba19c566079d8d673d57bd
parent 697423 c14544c1746821bc43803ee15da3c5a20c13e14d
child 740115 41df3bf83ab2cdf5716fd0304d2633c0b1a9eece
push id88993
push userbmo:gps@mozilla.com
push dateTue, 14 Nov 2017 00:01:59 +0000
reviewersnalexander
bugs1416052
milestone59.0a1
Bug 1416052 - Remove OBJDIR_TARGETS; r=nalexander Now that we require mach to run client.mk and mach only invokes client.mk for full builds (the "build" target) and configure (the "configure" target), we should no longer have anyone using client.mk as a proxy to make targets in the build backend. So remove that feature. MozReview-Commit-ID: BbaMdZHnRXy
client.mk
--- a/client.mk
+++ b/client.mk
@@ -76,19 +76,16 @@ endif
 endif
 
 MOZ_MAKE = $(MAKE) $(MOZ_MAKE_FLAGS) -C $(OBJDIR)
 
 # 'configure' scripts generated by autoconf.
 CONFIGURES := $(TOPSRCDIR)/configure
 CONFIGURES += $(TOPSRCDIR)/js/src/configure
 
-# Make targets that are going to be passed to the real build system
-OBJDIR_TARGETS = install export libs clean realclean distclean upload sdk installer package package-compare stage-package source-package l10n-check automation/build
-
 #######################################################################
 # Rules
 
 # The default rule is build
 build::
 
 ifndef MACH
 $(error client.mk must be used via `mach`. Try running \
@@ -221,35 +218,27 @@ ifneq (,$(CONFIG_STATUS))
 endif
 
 ####################################
 # Build it
 
 build::  $(OBJDIR)/Makefile $(OBJDIR)/config.status
 	+$(MOZ_MAKE)
 
-####################################
-# Other targets
-
-# Pass these target onto the real build system
-$(OBJDIR_TARGETS):: $(OBJDIR)/Makefile $(OBJDIR)/config.status
-	+$(MOZ_MAKE) $@
-
 ifdef MOZ_AUTOMATION
 build::
-	$(MAKE) -f $(TOPSRCDIR)/client.mk automation/build
+	+$(MOZ_MAKE) automation/build
 endif
 
 ifdef MOZBUILD_MANAGE_SCCACHE_DAEMON
 build::
 	# Terminate sccache server. This prints sccache stats.
 	-$(MOZBUILD_MANAGE_SCCACHE_DAEMON) --stop-server
 endif
 
 # This makefile doesn't support parallel execution. It does pass
 # MOZ_MAKE_FLAGS to sub-make processes, so they will correctly execute
 # in parallel.
 .NOTPARALLEL:
 
 .PHONY: \
     build \
-    configure \
-    $(OBJDIR_TARGETS)
+    configure