Bug 1416089 - Remove MEDIA_DECODING_PROCESS_CRASH telemetry. r?jolin draft
authorJames Cheng <jacheng@mozilla.com>
Fri, 10 Nov 2017 14:01:56 +0800
changeset 696080 25759f0d0105af35fd15b107de26bf466ddfca14
parent 695940 ed94dc665071d8d510688ff50bbedad2c7cb33ee
child 739778 2d9c9d457e5d269cbf9268297e41d1a7c5cf1b3a
push id88627
push userbmo:jacheng@mozilla.com
push dateFri, 10 Nov 2017 06:02:19 +0000
reviewersjolin
bugs1416089
milestone58.0a1
Bug 1416089 - Remove MEDIA_DECODING_PROCESS_CRASH telemetry. r?jolin MozReview-Commit-ID: Dqqmk6yUXPo
mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java
mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/RemoteManager.java
toolkit/components/telemetry/Histograms.json
toolkit/components/telemetry/histogram-whitelists.json
--- a/mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java
+++ b/mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java
@@ -360,22 +360,16 @@ public class GeckoApplication extends Ap
                     }
                 }
             });
         }
 
         GeckoAccessibility.setAccessibilityManagerListeners(this);
 
         AudioFocusAgent.getInstance().attachToContext(this);
-
-        RemoteManager.setCrashReporter(new RemoteManager.ICrashReporter() {
-            public void reportDecodingProcessCrash() {
-                Telemetry.addToHistogram(MEDIA_DECODING_PROCESS_CRASH, 1);
-            }
-        });
     }
 
     private class EventListener implements BundleEventListener
     {
         private void onProfileCreate(final String name, final String path) {
             // Add everything when we're done loading the distribution.
             final Context context = GeckoApplication.this;
             final GeckoProfile profile = GeckoProfile.get(context, name);
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/RemoteManager.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/RemoteManager.java
@@ -22,17 +22,16 @@ import java.util.List;
 import java.util.NoSuchElementException;
 
 import org.mozilla.gecko.gfx.GeckoSurface;
 
 public final class RemoteManager implements IBinder.DeathRecipient {
     private static final String LOGTAG = "GeckoRemoteManager";
     private static final boolean DEBUG = false;
     private static RemoteManager sRemoteManager = null;
-    private static ICrashReporter setCrashReporter = null;
 
     public synchronized static RemoteManager getInstance() {
         if (sRemoteManager == null) {
             sRemoteManager = new RemoteManager();
         }
 
         sRemoteManager.init();
         return sRemoteManager;
@@ -140,30 +139,16 @@ public final class RemoteManager impleme
                 return null;
             }
         } catch (RemoteException e) {
             e.printStackTrace();
             return null;
         }
     }
 
-    private void reportDecodingProcessCrash() {
-        if (setCrashReporter != null) {
-            setCrashReporter.reportDecodingProcessCrash();
-        }
-    }
-
-    public static void setCrashReporter(ICrashReporter reporter) {
-        setCrashReporter = reporter;
-    }
-
-    public interface ICrashReporter {
-        void reportDecodingProcessCrash();
-    }
-
     public synchronized IMediaDrmBridge createRemoteMediaDrmBridge(String keySystem,
                                                                    String stubId) {
         if (mRemote == null) {
             if (DEBUG) Log.d(LOGTAG, "createRemoteMediaDrmBridge failed due to not initialize");
             return null;
         }
         try {
             IMediaDrmBridge remoteBridge =
@@ -173,17 +158,16 @@ public final class RemoteManager impleme
             Log.e(LOGTAG, "Got exception during createRemoteMediaDrmBridge().", e);
             return null;
         }
     }
 
     @Override
     public void binderDied() {
         Log.e(LOGTAG, "remote codec is dead");
-        reportDecodingProcessCrash();
         handleRemoteDeath();
     }
 
     private synchronized void handleRemoteDeath() {
         mConnection.waitDisconnect();
 
         if (init() && recoverRemoteCodec()) {
             notifyError(false);
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -8581,25 +8581,16 @@
   "MEDIA_HLS_DECODER_SUCCESS": {
     "record_in_processes": ["main", "content"],
     "alert_emails": ["ajones@mozilla.com", "giles@mozilla.com"],
     "expires_in_version": "60",
     "kind": "boolean",
     "description": "Reports whether a decoder for an HTTP Live Streaming media type was created when requested.",
     "bug_numbers": [1262659]
   },
-  "MEDIA_DECODING_PROCESS_CRASH": {
-    "record_in_processes": ["main", "content"],
-    "alert_emails": ["bwu@mozilla.com", "jolin@mozilla.com", "jacheng@mozilla.com"],
-    "expires_in_version": "57",
-    "kind": "count",
-    "bug_numbers": [1297556, 1257777],
-    "description": "Records a value each time Fennec remote decoding process crashes unexpected while decoding media content.",
-    "releaseChannelCollection": "opt-out"
-  },
   "MEDIA_ANDROID_VIDEO_TUNNELING_SUPPORT": {
     "record_in_processes": ["main", "content"],
     "alert_emails": ["bwu@mozilla.com", "jolin@mozilla.com"],
     "expires_in_version": "60",
     "kind": "boolean",
     "description": "Records whether tunneled playback is supported by a video decoder when creating it.",
     "bug_numbers": [1403849]
   },
--- a/toolkit/components/telemetry/histogram-whitelists.json
+++ b/toolkit/components/telemetry/histogram-whitelists.json
@@ -1797,17 +1797,16 @@
     "FX_CONTENT_CRASH_NOT_SUBMITTED",
     "FX_CONTENT_CRASH_PRESENTED",
     "FX_SESSION_RESTORE_SEND_UPDATE_CAUSED_OOM",
     "FX_TOUCH_USED",
     "GEOLOCATION_ERROR",
     "JS_TELEMETRY_ADDON_EXCEPTIONS",
     "MASTER_PASSWORD_ENABLED",
     "MEDIA_CODEC_USED",
-    "MEDIA_DECODING_PROCESS_CRASH",
     "NETWORK_CONNECTION_COUNT",
     "NUMBER_OF_PROFILES",
     "ONBEFOREUNLOAD_PROMPT_COUNT",
     "OPENGL_COMPOSITING_FAILURE_ID",
     "PERMISSIONS_SQL_CORRUPTED",
     "PLUGIN_HANG_NOTICE_COUNT",
     "PRINT_COUNT",
     "PRINT_DIALOG_OPENED_COUNT",