Bug 1413500 - Disable video surface readback (for page thumbnail) on Android r=jgilbert draft
authorJames Willcox <snorp@snorp.net>
Tue, 21 Nov 2017 11:42:42 -0600
changeset 701446 be368724d4963deed1cc5fe64327f46145677e62
parent 701445 9ab100d692bf2e4515e534816ed64bf97682bc96
child 701594 be242e4fdd19f11735c0c715f593c8d3225fa922
push id90157
push userbmo:snorp@snorp.net
push dateTue, 21 Nov 2017 17:47:04 +0000
reviewersjgilbert
bugs1413500
milestone59.0a1
Bug 1413500 - Disable video surface readback (for page thumbnail) on Android r=jgilbert MozReview-Commit-ID: IDGl7OzBY82
gfx/layers/GLImages.h
--- a/gfx/layers/GLImages.h
+++ b/gfx/layers/GLImages.h
@@ -44,16 +44,22 @@ public:
   }
   bool GetContinuous() const {
     return mContinuous;
   }
   gl::OriginPos GetOriginPos() const {
     return mOriginPos;
   }
 
+  virtual already_AddRefed<gfx::SourceSurface> GetAsSourceSurface() override {
+    // We can implement this, but currently don't want to because it will cause the
+    // SurfaceTexture to be permanently bound to the snapshot readback context.
+    return nullptr;
+  }
+
   SurfaceTextureImage* AsSurfaceTextureImage() override {
     return this;
   }
 
 private:
   AndroidSurfaceTextureHandle mHandle;
   gfx::IntSize mSize;
   bool mContinuous;