bug 1235287 - set a longer ocsp request timeout in test_ocsp_stapling_expired.js to avoid intermittent failures on android r?jcj draft
authorDavid Keeler <dkeeler@mozilla.com>
Thu, 09 Nov 2017 09:40:28 -0800
changeset 695698 d04c28d9269ef9428ac794d9d9a15049395ac0e7
parent 695600 2bdf6eed0f64a51dfe099e089852533595f1a896
child 739677 cc4c590a8c0145033cbac59023969432c5b187e1
push id88506
push userbmo:dkeeler@mozilla.com
push dateThu, 09 Nov 2017 17:43:38 +0000
reviewersjcj
bugs1235287
milestone58.0a1
bug 1235287 - set a longer ocsp request timeout in test_ocsp_stapling_expired.js to avoid intermittent failures on android r?jcj MozReview-Commit-ID: 3CJqnQ4EGXn
security/manager/ssl/tests/unit/test_ocsp_stapling_expired.js
--- a/security/manager/ssl/tests/unit/test_ocsp_stapling_expired.js
+++ b/security/manager/ssl/tests/unit/test_ocsp_stapling_expired.js
@@ -26,16 +26,20 @@ function add_ocsp_test(aHost, aExpectedR
             "Should have made " + aExpectedRequestCount +
             " fallback OCSP request" + (aExpectedRequestCount == 1 ? "" : "s"));
     });
 }
 
 do_get_profile();
 Services.prefs.setBoolPref("security.ssl.enable_ocsp_stapling", true);
 Services.prefs.setIntPref("security.OCSP.enabled", 1);
+// Sometimes this test will fail on android due to an OCSP request timing out.
+// That aspect of OCSP requests is not what we're testing here, so we can just
+// bump the timeout and hopefully avoid these failures.
+Services.prefs.setIntPref("security.OCSP.timeoutMilliseconds.soft", 5000);
 Services.prefs.setIntPref("security.pki.sha1_enforcement_level", 4);
 var args = [["good", "default-ee", "unused", 0],
              ["expiredresponse", "default-ee", "unused", 0],
              ["oldvalidperiod", "default-ee", "unused", 0],
              ["revoked", "default-ee", "unused", 0],
              ["unknown", "default-ee", "unused", 0],
             ];
 var ocspResponses = generateOCSPResponses(args, "ocsp_certs");