Bug 1371293 - Fix remaining instances of no-multi-spaces after upgrading to ESLint 4. r?Mossop draft
authorMark Banner <standard8@mozilla.com>
Mon, 06 Nov 2017 13:40:13 +0000
changeset 697130 a265b451b551bcfc70a58efd37f35db4be9eb249
parent 697129 28fc0a847d1bd13679c03b9412239f55e84b7b5f
child 697131 e769d8b2e751baabd7c75c32cc7d59381fd4e851
push id88906
push userbmo:standard8@mozilla.com
push dateMon, 13 Nov 2017 12:27:39 +0000
reviewersMossop
bugs1371293
milestone59.0a1
Bug 1371293 - Fix remaining instances of no-multi-spaces after upgrading to ESLint 4. r?Mossop MozReview-Commit-ID: EL6qI2VDyT1
browser/base/content/urlbarBindings.xml
toolkit/components/printing/content/printPreviewBindings.xml
toolkit/content/widgets/button.xml
toolkit/content/widgets/dialog.xml
--- a/browser/base/content/urlbarBindings.xml
+++ b/browser/base/content/urlbarBindings.xml
@@ -1809,21 +1809,23 @@ file, You can obtain one at http://mozil
            results to the input field. -->
       <property name="margins"
                 onget="return this._margins;">
         <setter>
           <![CDATA[
           this._margins = val;
 
           if (val) {
+            /* eslint-disable no-multi-spaces */
             let paddingInCSS =
                 3   // .autocomplete-richlistbox padding-left/right
               + 6   // .ac-site-icon margin-inline-start
               + 16  // .ac-site-icon width
               + 6;  // .ac-site-icon margin-inline-end
+            /* eslint-enable no-multi-spaces */
             let actualVal = Math.round(val.start) - paddingInCSS;
             let actualValEnd = Math.round(val.end);
             this.style.setProperty("--item-padding-start", actualVal + "px");
             this.style.setProperty("--item-padding-end", actualValEnd + "px");
           } else {
             this.style.removeProperty("--item-padding-start");
             this.style.removeProperty("--item-padding-end");
           }
--- a/toolkit/components/printing/content/printPreviewBindings.xml
+++ b/toolkit/components/printing/content/printPreviewBindings.xml
@@ -259,17 +259,17 @@
               this.mPageTextBox.value = this.mPageTextBox.max;
             }
             pageNum = 0;
           } else if (aDirection) {
             // aDirection is either +1 or -1, and allows us to increment
             // or decrement our currently viewed page.
             this.mPageTextBox.valueNumber += aDirection;
             navType = nsIWebBrowserPrint.PRINTPREVIEW_GOTO_PAGENUM;
-            pageNum = this.mPageTextBox.value;  // TODO: back to valueNumber?
+            pageNum = this.mPageTextBox.value; // TODO: back to valueNumber?
           } else {
             // We're going to a specific page (aPageNum)
             navType = nsIWebBrowserPrint.PRINTPREVIEW_GOTO_PAGENUM;
             pageNum = aPageNum;
           }
 
           this.mMessageManager.sendAsyncMessage("Printing:Preview:Navigate", {
             navType,
--- a/toolkit/content/widgets/button.xml
+++ b/toolkit/content/widgets/button.xml
@@ -179,17 +179,17 @@
             event.preventDefault();
             window.document.commandDispatcher.advanceFocus();
             return;
           }
         }
 
         if (event.keyCode || event.charCode <= 32 || event.altKey ||
             event.ctrlKey || event.metaKey)
-          return;  // No printable char pressed, not a potential accesskey
+          return; // No printable char pressed, not a potential accesskey
 
         // Possible accesskey pressed
         var charPressedLower = String.fromCharCode(event.charCode).toLowerCase();
 
         // If the accesskey of the current button is pressed, just activate it
         if (this.accessKey.toLowerCase() == charPressedLower) {
           this.click();
           return;
--- a/toolkit/content/widgets/dialog.xml
+++ b/toolkit/content/widgets/dialog.xml
@@ -53,17 +53,17 @@
                 onget="return this.getAttribute('buttons');"
                 onset="this._configureButtons(val); return val;"/>
 
       <property name="defaultButton">
         <getter>
         <![CDATA[
           if (this.hasAttribute("defaultButton"))
             return this.getAttribute("defaultButton");
-          return "accept";  // default to the accept button
+          return "accept"; // default to the accept button
         ]]>
         </getter>
         <setter>
         <![CDATA[
           this._setDefaultButton(val);
           return val;
         ]]>
         </setter>