Bug 1408928 - Rename and enable browser_webconsole_closing_brackets.js in new console frontend; r=Honza. draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Tue, 07 Nov 2017 12:19:09 +0100
changeset 694120 fa0fd95292c31fe178a94496b671c4e443e8a6d8
parent 694116 2c690ac0c5e3685d3c05c11e5cb4524df6498a57
child 739255 ea5873aa0b86ac31fac876eff67a9bdd3fbe4807
push id88044
push userbmo:nchevobbe@mozilla.com
push dateTue, 07 Nov 2017 11:20:01 +0000
reviewersHonza
bugs1408928
milestone58.0a1
Bug 1408928 - Rename and enable browser_webconsole_closing_brackets.js in new console frontend; r=Honza. MozReview-Commit-ID: EEwk0mSD5Rs
devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_autocomplete_extraneous_closing_brackets.js
devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_closing_brackets.js
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -196,16 +196,17 @@ skip-if = true # Bug 1406060
 skip-if = true #	Bug 1403188
 # old console skip-if = e10s # Bug 1042253 - webconsole e10s tests
 [browser_jsterm_accessibility.js]
 [browser_jsterm_add_edited_input_to_history.js]
 [browser_jsterm_autocomplete_array_no_index.js]
 [browser_jsterm_autocomplete_cached_results.js]
 [browser_jsterm_autocomplete_crossdomain_iframe.js]
 [browser_jsterm_autocomplete_escape_key.js]
+[browser_jsterm_autocomplete_extraneous_closing_brackets.js]
 [browser_jsterm_autocomplete_helpers.js]
 [browser_jsterm_autocomplete_in_debugger_stackframe.js]
 [browser_jsterm_autocomplete_inside_text.js]
 [browser_jsterm_autocomplete_nav_and_tab_key.js]
 [browser_jsterm_autocomplete_return_key_no_selection.js]
 [browser_jsterm_autocomplete_return_key.js]
 [browser_jsterm_autocomplete-properties-with-non-alphanumeric-names.js]
 [browser_jsterm_copy_command.js]
@@ -239,18 +240,16 @@ skip-if = true # Bug 1408925
 skip-if = true #	Bug 1404400
 [browser_webconsole_chrome.js]
 skip-if = true # Bug 1408926
 [browser_webconsole_click_function_to_source.js]
 skip-if = true #	Bug 1406038
 [browser_webconsole_clickable_urls.js]
 [browser_webconsole_closing_after_completion.js]
 skip-if = true # Bug 1408927
-[browser_webconsole_closing_brackets.js]
-skip-if = true # Bug 1408928
 [browser_webconsole_closure_inspection.js]
 skip-if = true #	Bug 1405250
 [browser_webconsole_completion.js]
 skip-if = true # Bug 1408929
 [browser_webconsole_console_api_iframe.js]
 skip-if = true # Bug 1408930
 [browser_webconsole_console_dir.js]
 [browser_webconsole_console_dir_uninspectable.js]
rename from devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_closing_brackets.js
rename to devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_autocomplete_extraneous_closing_brackets.js
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_closing_brackets.js
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_autocomplete_extraneous_closing_brackets.js
@@ -5,25 +5,18 @@
 
 // Tests that, when the user types an extraneous closing bracket, no error
 // appears. See Bug 592442.
 
 "use strict";
 
 const TEST_URI = "data:text/html;charset=utf-8,test for bug 592442";
 
-add_task(function* () {
-  yield loadTab(TEST_URI);
-  let hud = yield openConsole();
-  hud.jsterm.clearOutput();
-  let jsterm = hud.jsterm;
-
-  jsterm.setInputValue("document.getElementById)");
+add_task(async function () {
+  let { jsterm } = await openNewTabAndConsole(TEST_URI);
 
-  let error = false;
   try {
-    jsterm.complete(jsterm.COMPLETE_HINT_ONLY);
+    await jstermSetValueAndComplete(jsterm, "document.getElementById)");
+    ok(true, "no error was thrown when an extraneous bracket was inserted");
   } catch (ex) {
-    error = true;
+    ok(false, "an error was thrown when an extraneous bracket was inserted")
   }
-
-  ok(!error, "no error was thrown when an extraneous bracket was inserted");
 });