bug 1409622 initialize mTime even in Stream AudioTimelineEvents r?padenot draft
authorKarl Tomlinson <karlt+@karlt.net>
Tue, 07 Nov 2017 13:14:22 +1300
changeset 693929 357cbff2b45b7f339166e1c67f0e9704470f0102
parent 681923 64a4f7fc64e353c84785c6fe775f1cb9a49b9cde
child 739203 104a3b75d4236b75a1b5ec9ae3b8b2f9a364d4c0
push id87985
push userktomlinson@mozilla.com
push dateTue, 07 Nov 2017 05:14:09 +0000
reviewerspadenot
bugs1409622
milestone58.0a1
bug 1409622 initialize mTime even in Stream AudioTimelineEvents r?padenot to avoid uninitialized read in WebAudioUtils::ConvertAudioTimelineEventToTicks() MozReview-Commit-ID: GHPGIrc0T2h
dom/media/webaudio/AudioEventTimeline.cpp
--- a/dom/media/webaudio/AudioEventTimeline.cpp
+++ b/dom/media/webaudio/AudioEventTimeline.cpp
@@ -80,16 +80,17 @@ AudioTimelineEvent::AudioTimelineEvent(M
   : mType(Stream)
   , mCurve(nullptr)
   , mStream(aStream)
   , mTimeConstant(0.0)
   , mDuration(0.0)
 #ifdef DEBUG
   , mTimeIsInTicks(false)
 #endif
+  , mTime(0.0)
 {
 }
 
 AudioTimelineEvent::AudioTimelineEvent(const AudioTimelineEvent& rhs)
 {
   PodCopy(this, &rhs, 1);
 
   if (rhs.mType == AudioTimelineEvent::SetValueCurve) {