Bug 1414995: Crash when publicsuffixlist could not be opened. r=nechen draft
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 06 Nov 2017 16:12:15 -0800
changeset 694422 8f4b13154f74ac358fea2c2693f546a95b7f46ca
parent 693772 4ea775c267be77107929d68799628a66027f3172
child 739328 ad4dd9e748bc9f3e111245c80871d2eff2138f43
push id88120
push usermichael.l.comella@gmail.com
push dateTue, 07 Nov 2017 19:05:39 +0000
reviewersnechen
bugs1414995
milestone58.0a1
Bug 1414995: Crash when publicsuffixlist could not be opened. r=nechen MozReview-Commit-ID: 2agnVzKLkzd
mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/publicsuffix/PublicSuffixPatterns.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/publicsuffix/PublicSuffixPatterns.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/publicsuffix/PublicSuffixPatterns.java
@@ -34,17 +34,17 @@ class PublicSuffixPatterns {
                     new BufferedInputStream(context.getAssets().open("publicsuffixlist"))));
 
             String line;
             while ((line = reader.readLine()) != null) {
                 EXACT.add(line);
             }
 
         } catch (IOException e) {
-            Log.e("Patterns", "IOException during loading public suffix list");
+            throw new IllegalStateException("resource publicsuffixlist could not be opened but is bundled with app", e);
         } finally {
             IOUtils.safeStreamClose(reader);
         }
 
         return EXACT;
     }