Bug 1414794 - Unbreak the lld usage by providing the right data structure r?froydnj draft
authorSylvestre Ledru <sledru@mozilla.com>
Mon, 06 Nov 2017 14:23:57 +0100
changeset 693543 2cf4a4c00dd24d2b6eb369b7c67dc8fa3b0f4799
parent 693519 dc45ee24c55d1061951956321bd8481d517ce22a
child 739070 538ce35523f69309798a546a14da8d3170a7051a
push id87845
push userbmo:sledru@mozilla.com
push dateMon, 06 Nov 2017 13:24:18 +0000
reviewersfroydnj
bugs1414794
milestone58.0a1
Bug 1414794 - Unbreak the lld usage by providing the right data structure r?froydnj MozReview-Commit-ID: 1caPjLBR4vS
build/moz.configure/toolchain.configure
--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -1503,18 +1503,18 @@ def select_linker(linker, c_compiler, de
     linker = linker[0] if linker else 'other'
     if linker in ('gold', 'bfd', 'other'):
         return enable_gnu_linker(linker == 'gold', c_compiler, developer_options,
                                  build_env, toolchain_flags, linker)
     if linker == 'lld':
         version_check = ['-Wl,--version']
         cmd_base = c_compiler.wrapper + \
             [c_compiler.compiler] + c_compiler.flags
-        lld = "-fuse-ld=" + linker
-        cmd = cmd_base + [lld] + version_check
+        lld = ["-fuse-ld=" + linker]
+        cmd = cmd_base + lld + version_check
         if 'LLD' in check_cmd_output(*cmd).decode('utf-8'):
             return namespace(
                 KIND='lld',
                 LINKER_FLAG=lld,
             )
         else:
             die("Could not use lld as linker")