Bug 1414213. P2 - don't continue reading if reader.Read(5) failed.
MozReview-Commit-ID: 1vNbACa9Vpv
--- a/media/libstagefright/binding/H264.cpp
+++ b/media/libstagefright/binding/H264.cpp
@@ -962,19 +962,21 @@ H264::HasSPS(const mozilla::MediaByteBuf
/* static */ uint8_t
H264::NumSPS(const mozilla::MediaByteBuffer* aExtraData)
{
if (!aExtraData || aExtraData->IsEmpty()) {
return 0;
}
BufferReader reader(aExtraData);
- const uint8_t* ptr = reader.Read(5);
+ if (!reader.Read(5)) {
+ return 0;
+ }
auto res = reader.ReadU8();
- if (!ptr || res.isErr()) {
+ if (res.isErr()) {
return 0;
}
return res.unwrap() & 0x1f;
}
/* static */ bool
H264::CompareExtraData(const mozilla::MediaByteBuffer* aExtraData1,
const mozilla::MediaByteBuffer* aExtraData2)