Bug 1414401 - Enable geckodriver on Linux i686 r=ted,whimboo draft
authorAndreas Tolfsen <ato@sny.no>
Fri, 03 Nov 2017 14:13:06 +0000
changeset 698347 3202702d8ae3423079aad512a3d7c8dc8e7408a3
parent 698261 45715ece25fcb064eee4f977ebd842d44a87f22b
child 698348 af0c35be289bff1c1fb4792d678dea307834cc86
push id89262
push userbmo:ato@sny.no
push dateWed, 15 Nov 2017 15:51:47 +0000
reviewersted, whimboo
bugs1414401
milestone59.0a1
Bug 1414401 - Enable geckodriver on Linux i686 r=ted,whimboo This patch enables building of geckodriver in CI on Linux i686. MozReview-Commit-ID: GkdHDJrzh2X
toolkit/moz.configure
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -1109,19 +1109,18 @@ set_config('ENABLE_MARIONETTE', marionet
 # geckodriver WebDriver implementation
 # ==============================================================
 option('--enable-geckodriver', help='Enable WebDriver implementation')
 
 @depends('--enable-geckodriver',
          'MOZ_AUTOMATION',
          compile_environment,
          cross_compiling,
-         hazard_analysis,
-         target)
-def geckodriver(enable, automation, compile_env, cross_compile, hazard, target):
+         hazard_analysis)
+def geckodriver(enable, automation, compile_env, cross_compile, hazard):
     """
     geckodriver is implied on supported platforms when MOZ_AUTOMATION
     is set, but we also provide the --enable-geckodriver option for
     developers to use.
 
     At the present time, we want individual developers to be able to
     opt-in to building geckodriver locally, and for it to be enabled by
     default on supported CI build platforms.
@@ -1129,18 +1128,17 @@ def geckodriver(enable, automation, comp
     if enable:
         if not compile_env:
             die("--enable-geckodriver is not available without a compile "
                 "environment. A geckodriver binary will be downloaded during "
                 "an artifact build by default where available.")
         return True
 
     if enable.origin == 'default':
-        linux32 = target.kernel == 'Linux' and target.cpu == 'x86'
-        broken_platforms = cross_compile or linux32 or hazard
+        broken_platforms = cross_compile or hazard
 
         if automation and compile_env and not broken_platforms:
             return True
 
 set_config('ENABLE_GECKODRIVER', geckodriver)
 
 # WebRTC
 # ========================================================