Bug 1414213. P1 - H264::NumSPS() should return 0 if aExtraData is empty. draft
authorJW Wang <jwwang@mozilla.com>
Fri, 03 Nov 2017 17:40:32 +0800
changeset 693398 89b573c7d46160fe3f0a6223bd99e4354db7d36b
parent 693397 ac9e66749940b8d9521d2a638159fd355066fb73
child 693399 bd9dc13064a91eb4cc98952c5980760d5e2624f0
push id87780
push userjwwang@mozilla.com
push dateMon, 06 Nov 2017 03:25:03 +0000
bugs1414213
milestone58.0a1
Bug 1414213. P1 - H264::NumSPS() should return 0 if aExtraData is empty. MozReview-Commit-ID: JTzEqYt9mQr
media/libstagefright/binding/H264.cpp
--- a/media/libstagefright/binding/H264.cpp
+++ b/media/libstagefright/binding/H264.cpp
@@ -957,17 +957,17 @@ H264::ExtractExtraData(const mozilla::Me
 H264::HasSPS(const mozilla::MediaByteBuffer* aExtraData)
 {
   return NumSPS(aExtraData) > 0;
 }
 
 /* static */ uint8_t
 H264::NumSPS(const mozilla::MediaByteBuffer* aExtraData)
 {
-  if (!aExtraData) {
+  if (!aExtraData || aExtraData->IsEmpty()) {
     return 0;
   }
 
   BufferReader reader(aExtraData);
   const uint8_t* ptr = reader.Read(5);
   auto res = reader.ReadU8();
   if (!ptr || res.isErr()) {
     return 0;