Bug 1413941 - Fix broken netmonitor launchpad regression from bug 1360457 r?honza draft
authorRicky Chien <ricky060709@gmail.com>
Thu, 02 Nov 2017 22:40:44 +0800
changeset 692404 9f57dbcd6ae2826413db28b32c188af9adb0290f
parent 692325 b2f459b88cab5525c785a7fa70a01be3e9cdcb23
child 738749 7e7d1cd8c12980bc13fe1e8b62b39365adbadc7a
push id87491
push userbmo:rchien@mozilla.com
push dateFri, 03 Nov 2017 02:16:52 +0000
reviewershonza
bugs1413941, 1360457
milestone58.0a1
Bug 1413941 - Fix broken netmonitor launchpad regression from bug 1360457 r?honza MozReview-Commit-ID: 6EzLlNfQ4FX
devtools/client/netmonitor/src/components/RequestList.js
devtools/client/netmonitor/src/components/RequestListEmptyNotice.js
devtools/client/netmonitor/src/components/Toolbar.js
--- a/devtools/client/netmonitor/src/components/RequestList.js
+++ b/devtools/client/netmonitor/src/components/RequestList.js
@@ -21,21 +21,22 @@ const { div } = DOM;
  * Request panel component
  */
 function RequestList({
   connector,
   isEmpty,
 }) {
   return (
     div({ className: "request-list-container" },
-      isEmpty ? RequestListEmptyNotice({connector}) : RequestListContent({connector}),
-      StatusBar(),
+      isEmpty ? RequestListEmptyNotice({ connector }) : RequestListContent({ connector }),
+      StatusBar({ connector }),
     )
   );
 }
 
 RequestList.displayName = "RequestList";
 
 RequestList.propTypes = {
+  connector: PropTypes.object.isRequired,
   isEmpty: PropTypes.bool.isRequired,
 };
 
 module.exports = RequestList;
--- a/devtools/client/netmonitor/src/components/RequestListEmptyNotice.js
+++ b/devtools/client/netmonitor/src/components/RequestListEmptyNotice.js
@@ -55,17 +55,17 @@ class RequestListEmptyNotice extends Com
             className: "devtools-button requests-list-reload-notice-button",
             "data-standalone": true,
             onClick: this.props.onReloadClick,
           },
           RELOAD_NOTICE_2
         ),
         span(null, RELOAD_NOTICE_3)
       ),
-      div({ className: "notice-perf-message" },
+      div({ className: "notice-perf-message empty-notice-element" },
         span(null, PERFORMANCE_NOTICE_1),
         button({
           title: PERFORMANCE_NOTICE_3,
           className: "devtools-button requests-list-perf-notice-button",
           "data-standalone": true,
           onClick: this.props.onPerfClick,
         }),
         span(null, PERFORMANCE_NOTICE_2),
--- a/devtools/client/netmonitor/src/components/Toolbar.js
+++ b/devtools/client/netmonitor/src/components/Toolbar.js
@@ -197,31 +197,31 @@ class Toolbar extends Component {
               className: "devtools-checkbox-label",
               title: ENABLE_PERSISTENT_LOGS_TOOLTIP,
             },
             input({
               id: "devtools-persistlog-checkbox",
               className: "devtools-checkbox",
               type: "checkbox",
               checked: persistentLogsEnabled,
-              onClick: togglePersistentLogs,
+              onChange: togglePersistentLogs,
             }),
             ENABLE_PERSISTENT_LOGS_LABEL
           ),
           label(
             {
               className: "devtools-checkbox-label",
               title: DISABLE_CACHE_TOOLTIP,
             },
             input({
               id: "devtools-cache-checkbox",
               className: "devtools-checkbox",
               type: "checkbox",
               checked: browserCacheDisabled,
-              onClick: toggleBrowserCache,
+              onChange: toggleBrowserCache,
             }),
             DISABLE_CACHE_LABEL,
           ),
         ),
         span({ className: "devtools-toolbar-group" },
           SearchBox({
             delay: FILTER_SEARCH_DELAY,
             keyShortcut: SEARCH_KEY_SHORTCUT,