Remove flush from RotatedBuffer::UpdateDestinationFrom (bug 1410919, r?nical) draft
authorRyan Hunt <rhunt@eqrion.net>
Mon, 23 Oct 2017 12:23:57 -0400
changeset 689607 bd32d8bb3afe02eb9884a099c4c63e00eb08ad73
parent 689081 083a9c84fbd09a6ff9bfecabbf773650842fe1c0
child 689608 c46b5724217a66875cabc7b513816fb84ebb5a11
push id87055
push userbmo:rhunt@eqrion.net
push dateTue, 31 Oct 2017 18:53:27 +0000
reviewersnical
bugs1410919
milestone58.0a1
Remove flush from RotatedBuffer::UpdateDestinationFrom (bug 1410919, r?nical) MozReview-Commit-ID: AKuz0sUj8Jf
gfx/layers/RotatedBuffer.cpp
--- a/gfx/layers/RotatedBuffer.cpp
+++ b/gfx/layers/RotatedBuffer.cpp
@@ -250,36 +250,32 @@ RotatedBuffer::UpdateDestinationFrom(con
     if (isClippingCheap) {
       gfxUtils::ClipToRegion(destDT, iter.mDrawRegion);
     }
 
     aSource.DrawBufferWithRotation(destDT, BUFFER_BLACK, 1.0, CompositionOp::OP_SOURCE);
     if (isClippingCheap) {
       destDT->PopClip();
     }
-    // Flush the destination before the sources become inaccessible (Unlock).
-    destDT->Flush();
     ReturnDrawTarget(destDT);
   }
 
   if (aSource.HaveBufferOnWhite() && HaveBufferOnWhite()) {
     DrawIterator whiteIter;
     while (DrawTarget* destDT =
       BorrowDrawTargetForQuadrantUpdate(aUpdateRect, BUFFER_WHITE, &whiteIter)) {
       bool isClippingCheap = IsClippingCheap(destDT, whiteIter.mDrawRegion);
       if (isClippingCheap) {
         gfxUtils::ClipToRegion(destDT, whiteIter.mDrawRegion);
       }
 
       aSource.DrawBufferWithRotation(destDT, BUFFER_WHITE, 1.0, CompositionOp::OP_SOURCE);
       if (isClippingCheap) {
         destDT->PopClip();
       }
-      // Flush the destination before the sources become inaccessible (Unlock).
-      destDT->Flush();
       ReturnDrawTarget(destDT);
     }
   }
 }
 
 static void
 WrapRotationAxis(int32_t* aRotationPoint, int32_t aSize)
 {