Bug 1412837 - check in searchbox but not in toolbar draft
authorFred Lin <gasolin@gmail.com>
Tue, 31 Oct 2017 14:34:41 +0800
changeset 689201 553f52935a5598e4540d5d49a13c4dc3736d3013
parent 689152 a359d0c10c0ed2af99c22acc5f538ac9c18e0bf4
child 738269 2821860f49ac145a1ec3f9df55b7be8d6c986431
push id86967
push userbmo:gasolin@mozilla.com
push dateTue, 31 Oct 2017 08:34:44 +0000
bugs1412837
milestone58.0a1
Bug 1412837 - check in searchbox but not in toolbar MozReview-Commit-ID: E9W2zVpnuGw
devtools/client/netmonitor/src/components/Toolbar.js
--- a/devtools/client/netmonitor/src/components/Toolbar.js
+++ b/devtools/client/netmonitor/src/components/Toolbar.js
@@ -87,27 +87,24 @@ class Toolbar extends Component {
 
   componentDidMount() {
     Services.prefs.addObserver(DEVTOOLS_ENABLE_PERSISTENT_LOG_PREF,
                                this.updatePersistentLogsEnabled);
     Services.prefs.addObserver(DEVTOOLS_DISABLE_CACHE_PREF,
                                this.updateBrowserCacheDisabled);
   }
 
-  shouldComponentUpdate(nextProps) {
-    return this.props.networkDetailsOpen !== nextProps.networkDetailsOpen
-    || this.props.networkDetailsToggleDisabled !== nextProps.networkDetailsToggleDisabled
-        || this.props.persistentLogsEnabled !== nextProps.persistentLogsEnabled
-        || this.props.browserCacheDisabled !== nextProps.browserCacheDisabled
-        || this.props.recording !== nextProps.recording
-        || !I.is(this.props.requestFilterTypes, nextProps.requestFilterTypes)
-    
-        // Filtered requests are useful only when searchbox is focused
-        || this.refs.searchbox.focused;
-  }
+  // shouldComponentUpdate(nextProps) {
+  //   return this.props.networkDetailsOpen !== nextProps.networkDetailsOpen
+  //     || this.props.networkDetailsToggleDisabled !== nextProps.networkDetailsToggleDisabled
+  //     || this.props.persistentLogsEnabled !== nextProps.persistentLogsEnabled
+  //     || this.props.browserCacheDisabled !== nextProps.browserCacheDisabled
+  //     || this.props.recording !== nextProps.recording
+  //     || !I.is(this.props.requestFilterTypes, nextProps.requestFilterTypes)
+  // }
 
   componentWillUnmount() {
     Services.prefs.removeObserver(DEVTOOLS_ENABLE_PERSISTENT_LOG_PREF,
                                   this.updatePersistentLogsEnabled);
     Services.prefs.removeObserver(DEVTOOLS_DISABLE_CACHE_PREF,
                                   this.updateBrowserCacheDisabled);
   }