Bug 1411608 - Test IS_NIGHTLY rather than MOZ_UPDATE_CHANNEL. r=Build draft
authorNick Alexander <nalexander@mozilla.com>
Mon, 30 Oct 2017 13:01:18 -0700
changeset 688829 cac1a26cde8b4f4e124da8027b23e0ffc2cd2f86
parent 688663 1c618b1a13662de7cec429f606367db3827b6dc7
child 688837 d62ab3472245774c7e9a9071df82832cf4cffc7e
child 688838 fe4248a397f40135ab1831f9985b7de2e488ee58
push id86872
push usernalexander@mozilla.com
push dateMon, 30 Oct 2017 20:04:00 +0000
reviewersBuild
bugs1411608
milestone58.0a1
Bug 1411608 - Test IS_NIGHTLY rather than MOZ_UPDATE_CHANNEL. r=Build The manipulations that determine whether we have a Release, Beta, or Nightly build are incredibly fragile, and this is one place where testing the narrow MOZ_UPDATE_CHANNEL for just "nightly" is causing issues. On other project branches, MOZ_UPDATE_CHANNEL will be "nightly-$PROJECT", like "nightly-oak", causing features to not be compiled. MozReview-Commit-ID: 29SxsMFb0EX
mobile/android/config/mozconfigs/common
--- a/mobile/android/config/mozconfigs/common
+++ b/mobile/android/config/mozconfigs/common
@@ -78,32 +78,32 @@ fi
 
 # MOZ_ANDROID_MMA depends on --with-leanplum-sdk-keyfile, and there's no default
 # keyfile set, so if we misconfigure beta or release, the builds will fail (at
 # configure time).
 if test "$MOZ_UPDATE_CHANNEL" = "release" ; then
     ac_add_options --with-leanplum-sdk-keyfile=/builds/leanplum-sdk-release.token
 elif test "$MOZ_UPDATE_CHANNEL" = "beta" ; then
     ac_add_options --with-leanplum-sdk-keyfile=/builds/leanplum-sdk-beta.token
-elif test "$MOZ_UPDATE_CHANNEL" = "nightly" ; then
+elif [ "x$IS_NIGHTLY" = "xyes" ] ; then
     ac_add_options --with-leanplum-sdk-keyfile=/builds/leanplum-sdk-nightly.token
 else
     ac_add_options --with-leanplum-sdk-keyfile="$topsrcdir/mobile/android/base/leanplum-sdk-sandbox.token"
 fi
 
 # MOZ_ANDROID_POCKET depends on --with-pocket-api-keyfile, and will
 # fail if MOZ_ANDROID_POCKET is specified but a keyfile is not. There's no default
 # keyfile set, so if we misconfigure beta or release or nightly, the builds will
 # fail (at configure time).
 # Otherwise, Pocket is not a critical component so it can be built with a dummy key.
 if test "$MOZ_UPDATE_CHANNEL" = "release" ; then
     ac_add_options --with-pocket-api-keyfile=/builds/pocket-api-release.token
 elif test "$MOZ_UPDATE_CHANNEL" = "beta" ; then
     ac_add_options --with-pocket-api-keyfile=/builds/pocket-api-beta.token
-elif test "$MOZ_UPDATE_CHANNEL" = "nightly" ; then
+elif [ "x$IS_NIGHTLY" = "xyes" ] ; then
     ac_add_options --with-pocket-api-keyfile=/builds/pocket-api-nightly.token
 else
     ac_add_options --with-pocket-api-keyfile="$topsrcdir/mobile/android/base/pocket-api-sandbox.token"
 fi
 
 export SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE=/builds/crash-stats-api.token
 
 # Package js shell.