Bug 1381375 - Show proper error message for 404 not found media source on video controls. r=jaws
MozReview-Commit-ID: JbMGBnlhH3w
--- a/toolkit/content/tests/widgets/test_videocontrols_error.html
+++ b/toolkit/content/tests/widgets/test_videocontrols_error.html
@@ -33,17 +33,17 @@
}));
testCases.push(() => new Promise(resolve => {
video.src = "invalid-path.ogg";
video.addEventListener("error", resolve);
}));
testCases.push(() => new Promise(resolve => {
- const errorType = "errorSrcNotSupported";
+ const errorType = "errorNoSource";
ok(!statusOverlay.hidden, `statusOverlay should show when ${errorType}`);
is(statusOverlay.getAttribute("error"), errorType, `statusOverlay should have correct error state: ${errorType}`);
is(statusIcon.getAttribute("type"), "error", `should show error icon when ${errorType}`);
resolve();
}));
--- a/toolkit/content/widgets/videocontrols.xml
+++ b/toolkit/content/widgets/videocontrols.xml
@@ -761,17 +761,19 @@
break;
case v.error.MEDIA_ERR_NETWORK:
error = "errorNetwork";
break;
case v.error.MEDIA_ERR_DECODE:
error = "errorDecode";
break;
case v.error.MEDIA_ERR_SRC_NOT_SUPPORTED:
- error = "errorSrcNotSupported";
+ error = v.networkState == v.NETWORK_NO_SOURCE ?
+ "errorNoSource" :
+ "errorSrcNotSupported";
break;
default:
error = "errorGeneric";
break;
}
} else if (v.networkState == v.NETWORK_NO_SOURCE) {
error = "errorNoSource";
} else {