Bug 1412222 - start_session should not ignore the result of connection attempts.
By silently ignoring the result from 'wait_for_port' results in a
delayed socket error, which sometimes can cause strange results
as seen on
bug 1410366.
MozReview-Commit-ID: 2ptIwX6upBG
--- a/testing/marionette/client/marionette_driver/marionette.py
+++ b/testing/marionette/client/marionette_driver/marionette.py
@@ -1217,17 +1217,17 @@ class Marionette(object):
# We're managing a binary which has terminated. Start it again
# and implicitely wait for the Marionette server to be ready.
if returncode is not None:
self.start_binary(timeout)
else:
# In the case when Marionette doesn't manage the binary wait until
# its server component has been started.
- self.wait_for_port(timeout=timeout)
+ self.raise_for_port(timeout=timeout)
self.client = transport.TcpTransport(
self.host,
self.port,
self.socket_timeout)
self.protocol, _ = self.client.connect()
body = capabilities