Bug 1411416 - Don't leak nsOfflineCacheUpdateService::mAllowedDomains. r=mayhemer draft
authorAndrew McCreight <continuation@gmail.com>
Wed, 25 Oct 2017 09:55:02 -0700
changeset 686870 a6a686ea5d3179eafd375335bccf9c0a36cacb97
parent 686869 3a87b01e61fd9d60f01faee880a969740823fd5d
child 737504 9c223c2d72e7616a11b8567ef5343e6a7c2996af
push id86330
push userbmo:continuation@gmail.com
push dateThu, 26 Oct 2017 14:50:11 +0000
reviewersmayhemer
bugs1411416
milestone58.0a1
Bug 1411416 - Don't leak nsOfflineCacheUpdateService::mAllowedDomains. r=mayhemer MozReview-Commit-ID: D9Bq3NZYaO6
uriloader/prefetch/nsOfflineCacheUpdateService.cpp
--- a/uriloader/prefetch/nsOfflineCacheUpdateService.cpp
+++ b/uriloader/prefetch/nsOfflineCacheUpdateService.cpp
@@ -252,16 +252,19 @@ nsOfflineCacheUpdateService::nsOfflineCa
     Preferences::AddBoolVarCache(&sAllowOfflineCache,
                                  "browser.cache.offline.enable",
                                  true);
 }
 
 nsOfflineCacheUpdateService::~nsOfflineCacheUpdateService()
 {
     gOfflineCacheUpdateService = nullptr;
+
+    delete mAllowedDomains;
+    mAllowedDomains = nullptr;
 }
 
 nsresult
 nsOfflineCacheUpdateService::Init()
 {
     // Observe xpcom-shutdown event
     nsCOMPtr<nsIObserverService> observerService =
       mozilla::services::GetObserverService();