Bug 1411498: delete unused sipcc states. r?bwc draft
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Tue, 24 Oct 2017 23:40:02 -0700
changeset 686323 f23206db845f0c7a4154d3291066af03e9121137
parent 684930 1488c7223fcc8fc19632664efa58b63d794a63db
child 737356 cfd226f3e9f1258aab9552def54e4e2240c0c6a5
push id86161
push userdrno@ohlmeier.org
push dateWed, 25 Oct 2017 18:50:37 +0000
reviewersbwc
bugs1411498
milestone58.0a1
Bug 1411498: delete unused sipcc states. r?bwc MozReview-Commit-ID: DnJrQk4hkYb
dom/media/PeerConnection.js
dom/webidl/PeerConnectionImplEnums.webidl
dom/webidl/PeerConnectionObserverEnums.webidl
media/webrtc/signaling/test/signaling_unittests.cpp
--- a/dom/media/PeerConnection.js
+++ b/dom/media/PeerConnection.js
@@ -1533,28 +1533,16 @@ class PeerConnectionObserver {
       case "IceConnectionState":
         this.handleIceConnectionStateChange(this._dompc._pc.iceConnectionState);
         break;
 
       case "IceGatheringState":
         this.handleIceGatheringStateChange(this._dompc._pc.iceGatheringState);
         break;
 
-      case "SdpState":
-        // No-op
-        break;
-
-      case "ReadyState":
-        // No-op
-        break;
-
-      case "SipccState":
-        // No-op
-        break;
-
       default:
         this._dompc.logWarning("Unhandled state type: " + state);
         break;
     }
   }
 
   onGetStatsSuccess(dict) {
     let pc = this._dompc;
--- a/dom/webidl/PeerConnectionImplEnums.webidl
+++ b/dom/webidl/PeerConnectionImplEnums.webidl
@@ -12,22 +12,16 @@ enum PCImplSignalingState {
   "SignalingStable",
   "SignalingHaveLocalOffer",
   "SignalingHaveRemoteOffer",
   "SignalingHaveLocalPranswer",
   "SignalingHaveRemotePranswer",
   "SignalingClosed",
 };
 
-enum PCImplSipccState {
-  "Idle",
-  "Starting",
-  "Started"
-};
-
 enum PCImplIceConnectionState {
     "new",
     "checking",
     "connected",
     "completed",
     "failed",
     "disconnected",
     "closed"
--- a/dom/webidl/PeerConnectionObserverEnums.webidl
+++ b/dom/webidl/PeerConnectionObserverEnums.webidl
@@ -5,12 +5,10 @@
  *
  * This is in a separate file so it can be shared with unittests.
  */
 
 enum PCObserverStateType {
     "None",
     "IceConnectionState",
     "IceGatheringState",
-    "SdpState",
-    "SipccState",
     "SignalingState"
 };
--- a/media/webrtc/signaling/test/signaling_unittests.cpp
+++ b/media/webrtc/signaling/test/signaling_unittests.cpp
@@ -413,20 +413,16 @@ TestObserver::OnStateChange(PCObserverSt
     MOZ_ASSERT(NS_IsMainThread());
     rv = pc->IceGatheringState(&goticegathering);
     NS_ENSURE_SUCCESS(rv, rv);
     std::cout
         << "ICE Gathering State: "
         << PCImplIceGatheringStateStrings[int(goticegathering)]
         << std::endl;
     break;
-  case PCObserverStateType::SdpState:
-    std::cout << "SDP State: " << std::endl;
-    // NS_ENSURE_SUCCESS(rv, rv);
-    break;
   case PCObserverStateType::SignalingState:
     MOZ_ASSERT(NS_IsMainThread());
     rv = pc->SignalingState(&gotsignaling);
     NS_ENSURE_SUCCESS(rv, rv);
     std::cout << "Signaling State: "
               << PCImplSignalingStateStrings[int(gotsignaling)]
               << std::endl;
     break;