Bug 1411027 - avoid using memset on a not-trivial type like nsTabSizes. r?waldo draft
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Tue, 24 Oct 2017 12:47:35 +0300
changeset 685270 afd905a0276944b224db4b68d3818197563c54db
parent 684511 ce1a86d3b4db161c95d1147676bbed839d7a4732
child 737108 7a09d0442d8b4cdd02883e919ba6dd2e9acb1856
push id85887
push userbmo:bpostelnicu@mozilla.com
push dateTue, 24 Oct 2017 09:48:34 +0000
reviewerswaldo
bugs1411027
milestone58.0a1
Bug 1411027 - avoid using memset on a not-trivial type like nsTabSizes. r?waldo MozReview-Commit-ID: 7bFwF4fs4gj
dom/base/nsWindowSizes.h
--- a/dom/base/nsWindowSizes.h
+++ b/dom/base/nsWindowSizes.h
@@ -14,17 +14,22 @@
 class nsTabSizes {
 public:
   enum Kind {
       DOM,        // DOM stuff.
       Style,      // Style stuff.
       Other       // Everything else.
   };
 
-  nsTabSizes() { mozilla::PodZero(this); }
+  nsTabSizes()
+    : mDom(0)
+    , mStyle(0)
+    , mOther(0)
+  {
+  }
 
   void add(Kind kind, size_t n)
   {
     switch (kind) {
       case DOM:   mDom   += n; break;
       case Style: mStyle += n; break;
       case Other: mOther += n; break;
       default:    MOZ_CRASH("bad nsTabSizes kind");