Bug 1411073 - av1: Log the output of generate_sources_mozbuild.sh. r?Build
By default, run_process() eats the output of the child process,
which means when it fails we get an exception about the return
code, but none of the error messages the script printed, with
makes the cause of failure opaque.
Resolve this by passing a log_name parameter, which will cause
the default line_handler to pass all lines of output to the
local logging instance, by default at the INFO level.
MozReview-Commit-ID: FIVRggeKT4f
--- a/python/mozbuild/mozbuild/vendor_aom.py
+++ b/python/mozbuild/mozbuild/vendor_aom.py
@@ -187,17 +187,17 @@ Please check manually and update the ven
makefile to obtain a list of source files, writing
these out in the appropriate format for our build
system to use.
'''
config_dir = mozpath.join(target, 'config')
self.log(logging.INFO, 'rm_confg_dir', {}, 'rm -rf %s' % config_dir)
mozfile.remove(config_dir)
self.run_process(args=['./generate_sources_mozbuild.sh'],
- cwd=target)
+ cwd=target, log_name='generate_sources')
def check_modified_files(self):
'''
Ensure that there aren't any uncommitted changes to files
in the working copy, since we're going to change some state
on the user.
'''
modified = self.repository.get_changed_files('M')