Bug 1410944 - Support uninstalling a duplicated registry entry we might have erroneously created. r?agashlin draft
authorMatt Howell <mhowell@mozilla.com>
Mon, 23 Oct 2017 11:04:59 -0700
changeset 684895 50509fdc1fa31356de25bdda36aa181881827835
parent 684703 d49501f258b105c5e2dcd0a59896ec1ceabf726b
child 736990 9effc87bf65b650e0dadf5ae06c9dac09b3ddd67
push id85753
push usermhowell@mozilla.com
push dateMon, 23 Oct 2017 18:05:28 +0000
reviewersagashlin
bugs1410944
milestone58.0a1
Bug 1410944 - Support uninstalling a duplicated registry entry we might have erroneously created. r?agashlin MozReview-Commit-ID: 3WR2NfAYFgl
browser/installer/windows/nsis/uninstaller.nsi
--- a/browser/installer/windows/nsis/uninstaller.nsi
+++ b/browser/installer/windows/nsis/uninstaller.nsi
@@ -317,25 +317,27 @@ Section "Uninstall"
   ; hashes, but only if they're for this installation.
   ReadRegStr $0 HKLM "Software\Classes\FirefoxHTML\DefaultIcon" ""
   StrCpy $0 $0 -2
   ${If} $0 == "$INSTDIR\${FileMainEXE}"
     DeleteRegKey HKLM "Software\Classes\FirefoxHTML"
     DeleteRegKey HKLM "Software\Classes\FirefoxURL"
     ${StrFilter} "${FileMainEXE}" "+" "" "" $R9
     DeleteRegKey HKLM "Software\Clients\StartMenuInternet\$R9"
+    DeleteRegValue HKLM "Software\RegisteredApplications" "$R9"
     DeleteRegValue HKLM "Software\RegisteredApplications" "${AppRegName}"
   ${EndIf}
   ReadRegStr $0 HKCU "Software\Classes\FirefoxHTML\DefaultIcon" ""
   StrCpy $0 $0 -2
   ${If} $0 == "$INSTDIR\${FileMainEXE}"
     DeleteRegKey HKCU "Software\Classes\FirefoxHTML"
     DeleteRegKey HKCU "Software\Classes\FirefoxURL"
     ${StrFilter} "${FileMainEXE}" "+" "" "" $R9
     DeleteRegKey HKCU "Software\Clients\StartMenuInternet\$R9"
+    DeleteRegValue HKCU "Software\RegisteredApplications" "$R9"
     DeleteRegValue HKCU "Software\RegisteredApplications" "${AppRegName}"
   ${EndIf}
 
   StrCpy $0 "Software\Microsoft\Windows\CurrentVersion\App Paths\${FileMainEXE}"
   ${If} $R9 == "false"
     DeleteRegKey HKLM "$0"
     DeleteRegKey HKCU "$0"
     StrCpy $0 "Software\Microsoft\MediaPlayer\ShimInclusionList\${FileMainEXE}"