Bug 1410891 - Fix prompt handle assertions. r?maja_zf
The first assertion was never run because it was passed a tuple
of a response value and a boolean. It now compares the response
value to the boolean using "is".
The second assertion mistakenly used the "==" (equals) operator
but should use "is" to get a better pytest error message.
MozReview-Commit-ID: HCCr5rExIYu
--- a/testing/web-platform/tests/webdriver/tests/element_retrieval/get_active_element.py
+++ b/testing/web-platform/tests/webdriver/tests/element_retrieval/get_active_element.py
@@ -98,17 +98,17 @@ def test_handle_prompt_accept(new_sessio
assert read_global(session, "accept1") is None
create_dialog(session)("confirm", text="accept #2", result_var="accept2")
response = session.transport.send("GET", "session/%s/element/active" % session.session_id)
assert_is_active_element(session, response)
assert_dialog_handled(session, "accept #2")
- assert read_global(session, "accept2"), True
+ assert read_global(session, "accept2") is True
create_dialog(session)("prompt", text="accept #3", result_var="accept3")
response = session.transport.send("GET", "session/%s/element/active" % session.session_id)
assert_is_active_element(session, response)
assert_dialog_handled(session, "accept #3")
assert read_global(session, "accept3") == ""
@@ -137,17 +137,17 @@ def test_handle_prompt_missing_value(ses
assert session.execute_script("return accept1") is None
create_dialog("confirm", text="dismiss #2", result_var="dismiss2")
response = session.transport.send("GET", "session/%s/element/active" % session.session_id)
assert_error(response, "unexpected alert open")
assert_dialog_handled(session, "dismiss #2")
- assert session.execute_script("return dismiss2;") == False
+ assert session.execute_script("return dismiss2") is False
create_dialog("prompt", text="dismiss #3", result_var="dismiss3")
response = session.transport.send("GET", "session/%s/element/active" % session.session_id)
assert_error(response, "unexpected alert open")
assert_dialog_handled(session, "dismiss #3")
assert session.execute_script("return dismiss3") is None