Bug 1410891 - Use "is" operator to compare responses. r?maja_zf draft
authorAndreas Tolfsen <ato@sny.no>
Mon, 23 Oct 2017 14:49:11 +0100
changeset 685987 fa0aaa1ac24bf61dbe3a525028aa4a80b15ccde1
parent 685986 75651d93975b7487114867afab30e4fd9c7ba226
child 685988 731bd24cbb693f2dbedb228326f2fee6e7c21a16
push id86059
push userbmo:ato@sny.no
push dateWed, 25 Oct 2017 07:55:16 +0000
reviewersmaja_zf
bugs1410891
milestone58.0a1
Bug 1410891 - Use "is" operator to compare responses. r?maja_zf The "is" operator tests if two objects are the same object, and does not consider the values of the two objects. This also gives a better pytest error message should the assertion fails. MozReview-Commit-ID: GOUek15TUPU
testing/web-platform/tests/webdriver/tests/element_retrieval/get_active_element.py
--- a/testing/web-platform/tests/webdriver/tests/element_retrieval/get_active_element.py
+++ b/testing/web-platform/tests/webdriver/tests/element_retrieval/get_active_element.py
@@ -8,17 +8,17 @@ def assert_result_is_active_element(sess
     describing an element reference and that the referenced element matches the
     element returned by the `activeElement` attribute of the current browsing
     context's active document."""
     assert result.status == 200
 
     from_js = session.execute_script("return document.activeElement;")
 
     if result.body["value"] is None:
-        assert from_js == None
+        assert from_js is None
     else:
         assert_same_element(session, result.body["value"], from_js)
 
 # > 1. If the current browsing context is no longer open, return error with
 # >    error code no such window.
 def test_closed_context(session, create_window):
     new_window = create_window()
     session.window_handle = new_window
@@ -48,35 +48,35 @@ def test_handle_prompt_dismiss(new_sessi
 
     create_dialog(session)("alert", text="dismiss #1", result_var="dismiss1")
 
     result = session.transport.send("GET",
                                     "session/%s/element/active" % session.session_id)
 
     assert_result_is_active_element(session, result)
     assert_dialog_handled(session, "dismiss #1")
-    assert session.execute_script("return dismiss1;") == None
+    assert session.execute_script("return dismiss1") is None
 
     create_dialog(session)("confirm", text="dismiss #2", result_var="dismiss2")
 
     result = session.transport.send("GET",
                                     "session/%s/element/active" % session.session_id)
 
     assert_result_is_active_element(session, result)
     assert_dialog_handled(session, "dismiss #2")
-    assert read_global(session, "dismiss2") == None
+    assert read_global(session, "dismiss2") is None
 
     create_dialog(session)("prompt", text="dismiss #3", result_var="dismiss3")
 
     result = session.transport.send("GET",
                                     "session/%s/element/active" % session.session_id)
 
     assert_result_is_active_element(session, result)
     assert_dialog_handled(session, "dismiss #3")
-    assert read_global(session, "dismiss3") == None
+    assert read_global(session, "dismiss3") is None
 
 # [...]
 # 2. Handle any user prompts and return its value if it is an error.
 # [...]
 # In order to handle any user prompts a remote end must take the following
 # steps:
 # 2. Run the substeps of the first matching user prompt handler:
 #
@@ -91,17 +91,17 @@ def test_handle_prompt_accept(new_sessio
     session.url = inline("<body><p>Hello, World!</p></body>")
     create_dialog(session)("alert", text="accept #1", result_var="accept1")
 
     result = session.transport.send("GET",
                                     "session/%s/element/active" % session.session_id)
 
     assert_result_is_active_element(session, result)
     assert_dialog_handled(session, "accept #1")
-    assert read_global(session, "accept1") == None
+    assert read_global(session, "accept1") is None
 
     create_dialog(session)("confirm", text="accept #2", result_var="accept2")
 
     result = session.transport.send("GET",
                                     "session/%s/element/active" % session.session_id)
 
     assert_result_is_active_element(session, result)
     assert_dialog_handled(session, "accept #2")
@@ -133,17 +133,17 @@ def test_handle_prompt_missing_value(ses
 
     create_dialog("alert", text="dismiss #1", result_var="dismiss1")
 
     result = session.transport.send("GET",
                                     "session/%s/element/active" % session.session_id)
 
     assert_error(result, "unexpected alert open")
     assert_dialog_handled(session, "dismiss #1")
-    assert session.execute_script("return accept1;") == None
+    assert session.execute_script("return accept1") is None
 
     create_dialog("confirm", text="dismiss #2", result_var="dismiss2")
 
     result = session.transport.send("GET",
                                     "session/%s/element/active" % session.session_id)
 
     assert_error(result, "unexpected alert open")
     assert_dialog_handled(session, "dismiss #2")
@@ -151,17 +151,17 @@ def test_handle_prompt_missing_value(ses
 
     create_dialog("prompt", text="dismiss #3", result_var="dismiss3")
 
     result = session.transport.send("GET",
                                     "session/%s/element/active" % session.session_id)
 
     assert_error(result, "unexpected alert open")
     assert_dialog_handled(session, "dismiss #3")
-    assert session.execute_script("return dismiss3;") == None
+    assert session.execute_script("return dismiss3") is None
 
 # > [...]
 # > 3. Let active element be the active element of the current browsing
 # >    context's document element.
 # > 4. Let active web element be the JSON Serialization of active element.
 # > 5. Return success with data active web element.
 def test_success_document(session):
     session.url = inline("""