Bug 1410355 - Re-enable Marionette unit tests for ASAN builds except crash tests. draft
authorHenrik Skupin <mail@hskupin.info>
Mon, 23 Oct 2017 10:30:08 +0200
changeset 684616 5dde7e898ccaf1279bc9169fd71aebbcec8f652b
parent 683863 d1e995c8640a191cd127e87273ec96cb2fabffa9
child 736919 b94767b37b45f539afad2870ed15003e99ce55a0
push id85676
push userbmo:hskupin@gmail.com
push dateMon, 23 Oct 2017 08:30:35 +0000
bugs1410355
milestone58.0a1
Bug 1410355 - Re-enable Marionette unit tests for ASAN builds except crash tests. For ASAN builds the crashreporter is not available. As such the unit tests for crash handling should not be executed. But it should be fine to re-enable all the other unit tests. MozReview-Commit-ID: BPFshl7vvqM
testing/marionette/harness/marionette_harness/tests/unit-tests.ini
testing/marionette/harness/marionette_harness/tests/unit/unit-tests.ini
--- a/testing/marionette/harness/marionette_harness/tests/unit-tests.ini
+++ b/testing/marionette/harness/marionette_harness/tests/unit-tests.ini
@@ -1,11 +1,10 @@
 # marionette unit tests
 [include:unit/unit-tests.ini]
-skip-if = asan # Bug 1223277, 1348961
 
 # layout tests
 [include:../../../../../layout/base/tests/marionette/manifest.ini]
 
 # microformats tests
 [include:../../../../../toolkit/components/microformats/manifest.ini]
 
 # migration tests
--- a/testing/marionette/harness/marionette_harness/tests/unit/unit-tests.ini
+++ b/testing/marionette/harness/marionette_harness/tests/unit/unit-tests.ini
@@ -117,10 +117,10 @@ skip-if = true # Bug 1293844, bug 138767
 [test_chrome.py]
 skip-if = appname == 'fennec'
 
 [test_addons.py]
 skip-if = appname == 'fennec' # Bug 1330598
 
 [test_select.py]
 [test_crash.py]
-skip-if = manage_instance == false || appname == 'fennec' # Bug 1298921, bug 1322993
+skip-if = asan | manage_instance == false || appname == 'fennec' # Bug 1298921, bug 1322993
 [test_localization.py]