Bug 1408918 - Rename and enable browser_webconsole_autocomplete_accessibility.js in new console frontend; r=Honza draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Mon, 23 Oct 2017 09:07:14 +0200
changeset 685993 4e755ebedb6360991b820a61a53544c604def4c4
parent 685992 be75c97c76b6e8c5a8a41926f7af8d25875258c1
child 685994 10101ebd0f300e6794b37db7f19c41c936683d7d
push id86060
push userbmo:nchevobbe@mozilla.com
push dateWed, 25 Oct 2017 08:02:33 +0000
reviewersHonza
bugs1408918
milestone58.0a1
Bug 1408918 - Rename and enable browser_webconsole_autocomplete_accessibility.js in new console frontend; r=Honza MozReview-Commit-ID: CknvP7M1rVJ
devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_accessibility.js
devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_autocomplete_accessibility.js
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -190,16 +190,17 @@ skip-if = true # Bug 1406060
 skip-if = true # Bug 1406060
 [browser_console_webconsole_ctrlw_close_tab.js]
 skip-if = true # Bug 1406060
 [browser_console_webconsole_iframe_messages.js]
 skip-if = true # Bug 1406060
 [browser_console_webconsole_private_browsing.js]
 skip-if = true #	Bug 1403188
 # old console skip-if = e10s # Bug 1042253 - webconsole e10s tests
+[browser_jsterm_accessibility.js]
 [browser_jsterm_add_edited_input_to_history.js]
 [browser_jsterm_autocomplete_helpers.js]
 [browser_jsterm_autocomplete-properties-with-non-alphanumeric-names.js]
 [browser_jsterm_copy_command.js]
 skip-if = true
 subsuite = clipboard
 # old console skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts
 [browser_jsterm_dollar.js]
@@ -210,18 +211,16 @@ subsuite = clipboard
 [browser_jsterm_no_input_change_and_tab_key_pressed.js]
 [browser_netmonitor_shows_reqs_in_webconsole.js]
 [browser_webconsole_allow_mixedcontent_securityerrors.js]
 tags = mcb
 skip-if = true #	Bug 1403452
 # old console skip-if = (os == 'win' && bits == 64) # Bug 1390001
 [browser_webconsole_assert.js]
 skip-if = true #	Bug 1403458
-[browser_webconsole_autocomplete_accessibility.js]
-skip-if = true # Bug 1408918
 [browser_webconsole_autocomplete_and_selfxss.js]
 subsuite = clipboard
 skip-if = true #	Bug 1404850
 # old console skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts
 [browser_webconsole_autocomplete_crossdomain_iframe.js]
 skip-if = true # Bug 1408919
 [browser_webconsole_autocomplete_in_debugger_stackframe.js]
 skip-if = true # Bug 1408920
rename from devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_autocomplete_accessibility.js
rename to devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_accessibility.js
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_autocomplete_accessibility.js
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_accessibility.js
@@ -5,56 +5,54 @@
 
 // Tests that the autocomplete input is being blurred and focused when selecting a value.
 // This will help screen-readers notify users of the value that was set in the input.
 
 "use strict";
 
 const TEST_URI = "data:text/html;charset=utf8,<p>test code completion";
 
-add_task(function* () {
-  yield loadTab(TEST_URI);
-
-  let hud = yield openConsole();
+add_task(async function () {
+  let hud = await openNewTabAndConsole(TEST_URI);
 
   let jsterm = hud.jsterm;
   let input = jsterm.inputNode;
 
   info("Type 'd' to open the autocomplete popup");
-  yield autocomplete(jsterm, "d");
+  await autocomplete(jsterm, "d");
 
   // Add listeners for focus and blur events.
   let wasBlurred = false;
   input.addEventListener("blur", () => {
     wasBlurred = true;
   }, {
     once: true
   });
 
   let wasFocused = false;
-  input.addEventListener("blur", () => {
+  input.addEventListener("focus", () => {
     ok(wasBlurred, "jsterm input received a blur event before received back the focus");
     wasFocused = true;
   }, {
     once: true
   });
 
   info("Close the autocomplete popup by simulating a TAB key event");
   let onPopupClosed = jsterm.autocompletePopup.once("popup-closed");
   EventUtils.synthesizeKey("VK_TAB", {});
 
   info("Wait for the autocomplete popup to be closed");
-  yield onPopupClosed;
+  await onPopupClosed;
 
   ok(wasFocused, "jsterm input received a focus event");
 });
 
-function* autocomplete(jsterm, value) {
+async function autocomplete(jsterm, value) {
   let popup = jsterm.autocompletePopup;
 
-  yield new Promise(resolve => {
+  await new Promise(resolve => {
     jsterm.setInputValue(value);
     jsterm.complete(jsterm.COMPLETE_HINT_ONLY, resolve);
   });
 
   ok(popup.isOpen && popup.itemCount > 0,
     "Autocomplete popup is open and contains suggestions");
 }