Bug 1402196 - Part 1. Don't add null range to aArrayOfRanges. r?masayuki
RangeItem::GetRange can return null, so we shouldn't add null range to
aArrayOfRanges.
MozReview-Commit-ID: Ci5VHeqE8km
--- a/editor/libeditor/HTMLEditRules.cpp
+++ b/editor/libeditor/HTMLEditRules.cpp
@@ -5888,17 +5888,20 @@ HTMLEditRules::GetNodesForOperation(
rv = BustUpInlinesAtRangeEndpoints(*item);
if (NS_FAILED(rv)) {
break;
}
}
// Then unregister the ranges
for (auto& item : rangeItemArray) {
htmlEditor->mRangeUpdater.DropRangeItem(item);
- aArrayOfRanges.AppendElement(item->GetRange());
+ RefPtr<nsRange> range = item->GetRange();
+ if (range) {
+ aArrayOfRanges.AppendElement(range);
+ }
}
NS_ENSURE_SUCCESS(rv, rv);
}
// Gather up a list of all the nodes
for (auto& range : aArrayOfRanges) {
DOMSubtreeIterator iter;
nsresult rv = iter.Init(*range);
NS_ENSURE_SUCCESS(rv, rv);