Bug 1405652 - Enable browser_webconsole_view_source.js in new console frontend; r=bgrins. draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Fri, 20 Oct 2017 08:58:07 +0200
changeset 683948 cbe235b44e9aefed6e1cdb96b037b80f63709cd9
parent 683395 9c6a4e51bcfa323105778ccfe8705f71d37e347f
child 736778 66a9aaf3a2a201a201e6ff091f530a00d21c359a
push id85518
push userbmo:nchevobbe@mozilla.com
push dateFri, 20 Oct 2017 16:17:51 +0000
reviewersbgrins
bugs1405652
milestone58.0a1
Bug 1405652 - Enable browser_webconsole_view_source.js in new console frontend; r=bgrins. MozReview-Commit-ID: DctteBfNgtC
devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_view_source.js
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -460,16 +460,14 @@ skip-if = true #	Bug 1405650
 # old console skip-if = (os == 'win' && bits == 64) # Bug 1390001
 [browser_webconsole_variables_view_dont_sort_non_sortable_classes_properties.js]
 skip-if = true #	Bug 1403196
 [browser_webconsole_variables_view_while_debugging.js]
 skip-if = true #	Bug 1403200
 [browser_webconsole_variables_view_while_debugging_and_inspecting.js]
 skip-if = true #	Bug 1403205
 [browser_webconsole_view_source.js]
-skip-if = true #	Bug 1405652
-# old console skip-if = (os == 'win' && bits == 64) # Bug 1390001
 [browser_webconsole_violation.js]
 skip-if = true #	Bug 1405245
 # old console skip-if = e10s && (os == 'win') # Bug 1264955
 [browser_webconsole_warn_about_replaced_api.js]
 [browser_webconsole_websocket.js]
 skip-if = true # Bug 1408950
\ No newline at end of file
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_view_source.js
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_view_source.js
@@ -6,47 +6,25 @@
 // Tests that source URLs in the Web Console can be clicked to display the
 // standard View Source window. As JS exceptions and console.log() messages always
 // have their locations opened in Debugger, we need to test a security message in
 // order to have it opened in the standard View Source window.
 
 "use strict";
 
 const TEST_URI = "https://example.com/browser/devtools/client/webconsole/" +
-                 "test/test-mixedcontent-securityerrors.html";
-
-add_task(function* () {
-  yield actuallyTest();
-});
+                 "new-console-output/test/mochitest/test-mixedcontent-securityerrors.html";
 
-add_task(function* () {
-  Services.prefs.setBoolPref("devtools.debugger.new-debugger-frontend", false);
-  yield actuallyTest();
-  Services.prefs.clearUserPref("devtools.debugger.new-debugger-frontend");
-});
-
-var actuallyTest = Task.async(function*() {
-  yield loadTab(TEST_URI);
-  let hud = yield openConsole(null);
+add_task(async function () {
+  let hud = await openNewTabAndConsole(TEST_URI);
   info("console opened");
 
-  let [result] = yield waitForMessages({
-    webconsole: hud,
-    messages: [{
-      text: "Blocked loading mixed active content",
-      category: CATEGORY_SECURITY,
-      severity: SEVERITY_ERROR,
-    }],
-  });
-
-  let msg = [...result.matched][0];
+  let msg = await waitFor(() => findMessage(hud, "Blocked loading mixed active content"));
   ok(msg, "error message");
   let locationNode = msg.querySelector(".message-location .frame-link-filename");
   ok(locationNode, "location node");
 
-  let onTabOpen = waitForTab();
-
-  EventUtils.sendMouseEvent({ type: "click" }, locationNode);
+  let onTabOpen = BrowserTestUtils.waitForNewTab(gBrowser, null, true);
 
-  let tab = yield onTabOpen;
+  locationNode.click();
+  let tab = await onTabOpen;
   ok(true, "the view source tab was opened in response to clicking the location node");
-  gBrowser.removeTab(tab);
 });