Bug 1405288 - Remove duplicateNode actor method check from the inspector draft
authorPatrick Brosset <pbrosset@mozilla.com>
Thu, 19 Oct 2017 11:05:10 +0200
changeset 701119 4deccbc18db863d63d221e3a25777e581ce5ec34
parent 701118 791f56889e1951ad20a1224f62f2f8c1524b22dc
child 701120 6788eb6f74a47eb5a5515034b7bce9503f06d793
push id90078
push userbmo:pbrosset@mozilla.com
push dateTue, 21 Nov 2017 08:39:27 +0000
bugs1405288, 1208864
milestone59.0a1
Bug 1405288 - Remove duplicateNode actor method check from the inspector This method was added in bug 1208864 2 years ago and shipped with Firefox 44. We support all the way to the latest ESR, which now is 52. So let's remove this backward compat code. MozReview-Commit-ID: AdTU63Oehi4
devtools/client/inspector/inspector.js
--- a/devtools/client/inspector/inspector.js
+++ b/devtools/client/inspector/inspector.js
@@ -214,26 +214,22 @@ Inspector.prototype = {
       console.error(e);
     }
   },
 
   /**
    * Figure out what features the backend supports
    */
   _detectActorFeatures: function () {
-    this._supportsDuplicateNode = false;
     this._supportsScrollIntoView = false;
 
     // Use getActorDescription first so that all actorHasMethod calls use
     // a cached response from the server.
     return this._target.getActorDescription("domwalker").then(desc => {
       return promise.all([
-        this._target.actorHasMethod("domwalker", "duplicateNode").then(value => {
-          this._supportsDuplicateNode = value;
-        }).catch(console.error),
         this._target.actorHasMethod("domnode", "scrollIntoView").then(value => {
           this._supportsScrollIntoView = value;
         }).catch(console.error)
       ]);
     });
   },
 
   _deferredOpen: async function (defaultSelection) {
@@ -1290,17 +1286,16 @@ Inspector.prototype = {
       label: INSPECTOR_L10N.getStr("inspectorAddNode.label"),
       accesskey: INSPECTOR_L10N.getStr("inspectorAddNode.accesskey"),
       disabled: !this.canAddHTMLChild(),
       click: () => this.addNode(),
     }));
     menu.append(new MenuItem({
       id: "node-menu-duplicatenode",
       label: INSPECTOR_L10N.getStr("inspectorDuplicateNode.label"),
-      hidden: !this._supportsDuplicateNode,
       disabled: !isDuplicatableElement,
       click: () => this.duplicateNode(),
     }));
     menu.append(new MenuItem({
       id: "node-menu-delete",
       label: INSPECTOR_L10N.getStr("inspectorHTMLDelete.label"),
       accesskey: INSPECTOR_L10N.getStr("inspectorHTMLDelete.accesskey"),
       disabled: !isEditableElement,