Bug 1405288 - Remove duplicateNode actor method check from the inspector
This method was added in
bug 1208864 2 years ago and shipped with Firefox 44.
We support all the way to the latest ESR, which now is 52.
So let's remove this backward compat code.
MozReview-Commit-ID: AdTU63Oehi4
--- a/devtools/client/inspector/inspector.js
+++ b/devtools/client/inspector/inspector.js
@@ -214,26 +214,22 @@ Inspector.prototype = {
console.error(e);
}
},
/**
* Figure out what features the backend supports
*/
_detectActorFeatures: function () {
- this._supportsDuplicateNode = false;
this._supportsScrollIntoView = false;
// Use getActorDescription first so that all actorHasMethod calls use
// a cached response from the server.
return this._target.getActorDescription("domwalker").then(desc => {
return promise.all([
- this._target.actorHasMethod("domwalker", "duplicateNode").then(value => {
- this._supportsDuplicateNode = value;
- }).catch(console.error),
this._target.actorHasMethod("domnode", "scrollIntoView").then(value => {
this._supportsScrollIntoView = value;
}).catch(console.error)
]);
});
},
_deferredOpen: async function (defaultSelection) {
@@ -1290,17 +1286,16 @@ Inspector.prototype = {
label: INSPECTOR_L10N.getStr("inspectorAddNode.label"),
accesskey: INSPECTOR_L10N.getStr("inspectorAddNode.accesskey"),
disabled: !this.canAddHTMLChild(),
click: () => this.addNode(),
}));
menu.append(new MenuItem({
id: "node-menu-duplicatenode",
label: INSPECTOR_L10N.getStr("inspectorDuplicateNode.label"),
- hidden: !this._supportsDuplicateNode,
disabled: !isDuplicatableElement,
click: () => this.duplicateNode(),
}));
menu.append(new MenuItem({
id: "node-menu-delete",
label: INSPECTOR_L10N.getStr("inspectorHTMLDelete.label"),
accesskey: INSPECTOR_L10N.getStr("inspectorHTMLDelete.accesskey"),
disabled: !isEditableElement,