Bug 1408916 - Rename and enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend; r=bgrins.
MozReview-Commit-ID: DCFWNLGhCSM
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -191,16 +191,17 @@ skip-if = true # Bug 1406060
[browser_console_webconsole_ctrlw_close_tab.js]
skip-if = true # Bug 1406060
[browser_console_webconsole_iframe_messages.js]
skip-if = true # Bug 1406060
[browser_console_webconsole_private_browsing.js]
skip-if = true # Bug 1403188
# old console skip-if = e10s # Bug 1042253 - webconsole e10s tests
[browser_jsterm_add_edited_input_to_history.js]
+[browser_jsterm_autocomplete-properties-with-non-alphanumeric-names.js]
[browser_jsterm_copy_command.js]
skip-if = true
subsuite = clipboard
# old console skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts
[browser_jsterm_dollar.js]
[browser_jsterm_history_persist.js]
[browser_jsterm_inspect.js]
[browser_jsterm_no_autocompletion_on_defined_variables.js]
@@ -208,18 +209,16 @@ subsuite = clipboard
[browser_jsterm_no_input_change_and_tab_key_pressed.js]
[browser_netmonitor_shows_reqs_in_webconsole.js]
[browser_webconsole_allow_mixedcontent_securityerrors.js]
tags = mcb
skip-if = true # Bug 1403452
# old console skip-if = (os == 'win' && bits == 64) # Bug 1390001
[browser_webconsole_assert.js]
skip-if = true # Bug 1403458
-[browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js]
-skip-if = true # Bug 1408916
[browser_webconsole_autocomplete_JSTerm_helpers.js]
skip-if = true # Bug 1408917
[browser_webconsole_autocomplete_accessibility.js]
skip-if = true # Bug 1408918
[browser_webconsole_autocomplete_and_selfxss.js]
subsuite = clipboard
skip-if = true # Bug 1404850
# old console skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts
rename from devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js
rename to devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_autocomplete-properties-with-non-alphanumeric-names.js
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_autocomplete-properties-with-non-alphanumeric-names.js
@@ -2,46 +2,38 @@
/* vim: set ft=javascript ts=2 et sw=2 tw=80: */
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
// Test that properties starting with underscores or dollars can be
// autocompleted (bug 967468).
-
-add_task(function* () {
- const TEST_URI = "data:text/html;charset=utf8,test autocompletion with " +
- "$ or _";
- yield loadTab(TEST_URI);
-
- function* autocomplete(term) {
- let deferred = defer();
+const TEST_URI = "data:text/html;charset=utf8,test autocompletion with $ or _";
- jsterm.setInputValue(term);
- jsterm.complete(jsterm.COMPLETE_HINT_ONLY, deferred.resolve);
-
- yield deferred.promise;
+add_task(async function () {
+ let { jsterm } = await openNewTabAndConsole(TEST_URI);
- ok(popup.itemCount > 0,
- "There's " + popup.itemCount + " suggestions for '" + term + "'");
- }
-
- let { jsterm } = yield openConsole();
- let popup = jsterm.autocompletePopup;
-
- yield jsterm.execute("var testObject = {$$aaab: '', $$aaac: ''}");
+ await jsterm.execute("var testObject = {$$aaab: '', $$aaac: ''}");
// Should work with bug 967468.
- yield autocomplete("Object.__d");
- yield autocomplete("testObject.$$a");
+ await testAutocomplete(jsterm, "Object.__d");
+ await testAutocomplete(jsterm, "testObject.$$a");
// Here's when things go wrong in bug 967468.
- yield autocomplete("Object.__de");
- yield autocomplete("testObject.$$aa");
+ await testAutocomplete(jsterm, "Object.__de");
+ await testAutocomplete(jsterm, "testObject.$$aa");
// Should work with bug 1207868.
- yield jsterm.execute("let foobar = {a: ''}; const blargh = {a: 1};");
- yield autocomplete("foobar");
- yield autocomplete("blargh");
- yield autocomplete("foobar.a");
- yield autocomplete("blargh.a");
+ await jsterm.execute("let foobar = {a: ''}; const blargh = {a: 1};");
+ await testAutocomplete(jsterm, "foobar");
+ await testAutocomplete(jsterm, "blargh");
+ await testAutocomplete(jsterm, "foobar.a");
+ await testAutocomplete(jsterm, "blargh.a");
});
+
+async function testAutocomplete(jsterm, inputString) {
+ jsterm.setInputValue(inputString);
+ await new Promise(resolve => jsterm.complete(jsterm.COMPLETE_HINT_ONLY, resolve));
+
+ let popup = jsterm.autocompletePopup;
+ ok(popup.itemCount > 0, `There's ${popup.itemCount} suggestions for '${inputString}'`);
+}